From: Eric Blake <eblake@redhat.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>, qemu-devel@nongnu.org
Cc: jan.kiszka@siemens.com,
Benjamin Drung <benjamin.drung@profitbricks.com>,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PULL 1/9] slirp: Add domainname option to slirp's DHCP server
Date: Thu, 31 May 2018 14:42:01 -0500 [thread overview]
Message-ID: <fa8b7009-5bb1-fe4e-71eb-f9a7652973c3@redhat.com> (raw)
In-Reply-To: <20180531192237.3994-2-samuel.thibault@ens-lyon.org>
On 05/31/2018 02:22 PM, Samuel Thibault wrote:
> From: Benjamin Drung <benjamin.drung@profitbricks.com>
>
> This patch will allow the user to include the domainname option in
> replies from the built-in DHCP server.
>
> Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> net/slirp.c | 12 +++++++++---
> qapi/net.json | 4 ++++
> qemu-options.hx | 7 +++++--
> slirp/bootp.c | 8 ++++++++
> slirp/libslirp.h | 2 +-
> slirp/slirp.c | 4 +++-
> slirp/slirp.h | 1 +
> 7 files changed, 31 insertions(+), 7 deletions(-)
> +++ b/qapi/net.json
> @@ -160,6 +160,9 @@
> # @dnssearch: list of DNS suffixes to search, passed as DHCP option
> # to the guest
> #
> +# @domainname: guest-visible domain name of the virtual nameserver
> +# (since 2.12)
This missed 2.12; we'll need a followup patch that updates it to 3.0.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-05-31 19:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 19:22 [Qemu-devel] [PULL 0/9] slirp updates Samuel Thibault
2018-05-31 19:22 ` [Qemu-devel] [PULL 1/9] slirp: Add domainname option to slirp's DHCP server Samuel Thibault
2018-05-31 19:42 ` Eric Blake [this message]
2018-05-31 19:22 ` [Qemu-devel] [PULL 2/9] slirp: disable Nagle in outgoing connections Samuel Thibault
2018-05-31 19:22 ` [Qemu-devel] [PULL 3/9] slirp: disable Nagle in ingoing connections Samuel Thibault
2018-05-31 19:22 ` [Qemu-devel] [PULL 4/9] slirp/debug: Print IP addresses in human readable form Samuel Thibault
2018-05-31 19:22 ` [Qemu-devel] [PULL 5/9] net/slirp: Convert atoi to qemu_strtoi to allow error checking Samuel Thibault
2018-05-31 19:22 ` [Qemu-devel] [PULL 6/9] slirp: Send window updates to guest after window was closed Samuel Thibault
2018-05-31 19:22 ` [Qemu-devel] [PULL 7/9] slirp/ncsi: fix "Get Version ID" payload length Samuel Thibault
2018-05-31 19:22 ` [Qemu-devel] [PULL 8/9] slirp/ncsi: add a "Get Parameters" response Samuel Thibault
2018-05-31 19:22 ` [Qemu-devel] [PULL 9/9] slirp/ncsi: add checksum support Samuel Thibault
2018-05-31 19:40 ` [Qemu-devel] [PULL 0/9] slirp updates no-reply
2018-06-01 13:50 ` Peter Maydell
2018-06-01 13:57 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa8b7009-5bb1-fe4e-71eb-f9a7652973c3@redhat.com \
--to=eblake@redhat.com \
--cc=benjamin.drung@profitbricks.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).