From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D34E3C433B4 for ; Tue, 4 May 2021 17:21:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44D1061176 for ; Tue, 4 May 2021 17:21:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44D1061176 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldyjr-000302-5v for qemu-devel@archiver.kernel.org; Tue, 04 May 2021 13:21:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldyih-00022w-PQ for qemu-devel@nongnu.org; Tue, 04 May 2021 13:20:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:39118) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldyiX-0002Az-3P for qemu-devel@nongnu.org; Tue, 04 May 2021 13:20:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620148815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oQyzZDdWTEbgOfKw0LYtCYYQ9awQVGeK+8gw2Y5BiY4=; b=VbpDgNHsCAMt0zaLmz4BebDSnxMl6IEkWhENuCgMvzxbepdJ5HLvv5wEWIBVJs9cbtW0+K EDsh+GpMHmUbnuJPTyuKXIkdlT72LmwA4AqnIclnm3AQ4iYH1X8JkNvRdh0ewy+GSkmGkt ws893FSTaTI2TdtUEjpyw2QEFLCOfak= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-440-LmLmU8q7OO-Hm95BYfklfw-1; Tue, 04 May 2021 13:20:11 -0400 X-MC-Unique: LmLmU8q7OO-Hm95BYfklfw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6729D107ACCD; Tue, 4 May 2021 17:20:10 +0000 (UTC) Received: from [10.3.114.144] (ovpn-114-144.phx2.redhat.com [10.3.114.144]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F3DE26090F; Tue, 4 May 2021 17:20:09 +0000 (UTC) Subject: Re: [PATCH] migration: do not restart VM after successful snapshot-load To: Paolo Bonzini , qemu-devel@nongnu.org References: <20210504165826.618801-1-pbonzini@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Tue, 4 May 2021 12:20:09 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210504165826.618801-1-pbonzini@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.697, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dgilbert@redhat.com, qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/4/21 11:58 AM, Paolo Bonzini wrote: > The HMP loadvm code is calling load_snapshot rather than > qmp_snapshot_load, in order to bypass the job infrastructure. The code > around it is almost the same, with one difference: hmp_loadvm is > restarting the VM if load_snapshot fails, qmp_snapshot_load is doing so > if load_snapshot succeeds. > > Fix the bug in QMP by moving the common code to load_snapshot. > > Cc: qemu-stable@nongnu.org > Signed-off-by: Paolo Bonzini > --- > migration/savevm.c | 16 ++++++++-------- > monitor/hmp-cmds.c | 7 +------ > 2 files changed, 9 insertions(+), 14 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org