From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91FA7C43334 for ; Thu, 23 Jun 2022 15:11:22 +0000 (UTC) Received: from localhost ([::1]:35596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o4OUL-0001R8-HX for qemu-devel@archiver.kernel.org; Thu, 23 Jun 2022 11:11:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4OSv-0008Qd-Aq for qemu-devel@nongnu.org; Thu, 23 Jun 2022 11:09:53 -0400 Received: from smtpout3.mo529.mail-out.ovh.net ([46.105.54.81]:44859) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4OSt-0005vi-5d for qemu-devel@nongnu.org; Thu, 23 Jun 2022 11:09:52 -0400 Received: from mxplan5.mail.ovh.net (unknown [10.108.20.191]) by mo529.mail-out.ovh.net (Postfix) with ESMTPS id 4DE1611059C02; Thu, 23 Jun 2022 17:09:46 +0200 (CEST) Received: from kaod.org (37.59.142.104) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Thu, 23 Jun 2022 17:09:45 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-104R0059f4c54c9-d024-45c3-8745-8ed4cc28c296, 1905447EDF4A6B95D61F03ED56167C5A36471571) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: Date: Thu, 23 Jun 2022 17:09:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Subject: Re: [PATCH 01/14] sysbus: Remove sysbus_mmio_unmap To: Peter Delevoryas CC: , , , , , , <"i.mitsyanko@gmail.com.mst"@redhat.com>, , , , , , , References: <20220623095825.2038562-1-pdel@fb.com> <20220623095825.2038562-2-pdel@fb.com> Content-Language: en-US In-Reply-To: <20220623095825.2038562-2-pdel@fb.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.104] X-ClientProxiedBy: DAG2EX1.mxp5.local (172.16.2.11) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: 808c79e5-f4c2-4436-ac52-07d2351cc492 X-Ovh-Tracer-Id: 9383812776294583169 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudefjedgkeeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfhffuvfevfhgjtgfgihesthekredttdefjeenucfhrhhomhepveorughrihgtpgfnvggpifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpedvhffhvdehgfelvddtjeeuleevfeettdejgeetuedtveettedufeefueefvdetgfenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdpnhgspghrtghpthhtohepuddprhgtphhtthhopehkvhhmsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdfovfetjfhoshhtpehmohehvdel Received-SPF: pass client-ip=46.105.54.81; envelope-from=clg@kaod.org; helo=smtpout3.mo529.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/23/22 11:58, Peter Delevoryas wrote: > Cedric removed usage of this function in a previous commit. > > Fixes: 981b1c6266c6 ("spapr/xive: rework the mapping the KVM memory regions") > Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Thanks, C. > --- > hw/core/sysbus.c | 10 ---------- > include/hw/sysbus.h | 1 - > 2 files changed, 11 deletions(-) > > diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c > index 05c1da3d31..637e18f247 100644 > --- a/hw/core/sysbus.c > +++ b/hw/core/sysbus.c > @@ -154,16 +154,6 @@ static void sysbus_mmio_map_common(SysBusDevice *dev, int n, hwaddr addr, > } > } > > -void sysbus_mmio_unmap(SysBusDevice *dev, int n) > -{ > - assert(n >= 0 && n < dev->num_mmio); > - > - if (dev->mmio[n].addr != (hwaddr)-1) { > - memory_region_del_subregion(get_system_memory(), dev->mmio[n].memory); > - dev->mmio[n].addr = (hwaddr)-1; > - } > -} > - > void sysbus_mmio_map(SysBusDevice *dev, int n, hwaddr addr) > { > sysbus_mmio_map_common(dev, n, addr, false, 0); > diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h > index 3564b7b6a2..153ef20695 100644 > --- a/include/hw/sysbus.h > +++ b/include/hw/sysbus.h > @@ -82,7 +82,6 @@ qemu_irq sysbus_get_connected_irq(SysBusDevice *dev, int n); > void sysbus_mmio_map(SysBusDevice *dev, int n, hwaddr addr); > void sysbus_mmio_map_overlap(SysBusDevice *dev, int n, hwaddr addr, > int priority); > -void sysbus_mmio_unmap(SysBusDevice *dev, int n); > void sysbus_add_io(SysBusDevice *dev, hwaddr addr, > MemoryRegion *mem); > MemoryRegion *sysbus_address_space(SysBusDevice *dev);