From: Paolo Bonzini <pbonzini@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/7] blockjob: record time of last yield
Date: Thu, 14 Dec 2017 09:38:26 +0100 [thread overview]
Message-ID: <fad7ac35-e2be-a7b0-078c-4aa4c3dd2905@redhat.com> (raw)
In-Reply-To: <20171214005953.8898-2-jsnow@redhat.com>
On 14/12/2017 01:59, John Snow wrote:
> qemu_coroutine_yield();
> + job->last_yield_ns = qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
This is not the time the job has yielded control, but the time the job
has gotten it back. Is it intended?
Thanks,
Paolo
next prev parent reply other threads:[~2017-12-14 8:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 0:59 [Qemu-devel] [PATCH 0/7] blockjob: refactor mirror_throttle John Snow
2017-12-14 0:59 ` [Qemu-devel] [PATCH 1/7] blockjob: record time of last yield John Snow
2017-12-14 8:38 ` Paolo Bonzini [this message]
2017-12-14 15:55 ` John Snow
2017-12-18 14:22 ` Stefan Hajnoczi
2017-12-14 0:59 ` [Qemu-devel] [PATCH 2/7] blockjob: consolidate SLICE_TIME definition John Snow
2017-12-14 8:51 ` Paolo Bonzini
2017-12-18 14:23 ` Stefan Hajnoczi
2018-01-02 20:29 ` Jeff Cody
2017-12-14 0:59 ` [Qemu-devel] [PATCH 3/7] blockjob: create block_job_throttle John Snow
2017-12-14 8:39 ` Paolo Bonzini
2017-12-14 15:57 ` John Snow
2017-12-18 14:27 ` Stefan Hajnoczi
2018-01-02 21:23 ` Jeff Cody
2017-12-14 0:59 ` [Qemu-devel] [PATCH 4/7] blockjob: allow block_job_throttle to take delay_ns John Snow
2017-12-14 8:49 ` Paolo Bonzini
2017-12-14 16:06 ` John Snow
2017-12-14 17:21 ` Paolo Bonzini
2017-12-14 17:22 ` John Snow
2017-12-14 17:23 ` Paolo Bonzini
2017-12-14 0:59 ` [Qemu-devel] [PATCH 5/7] block/commit: use block_job_throttle John Snow
2017-12-14 8:50 ` Paolo Bonzini
2017-12-18 14:29 ` Stefan Hajnoczi
2017-12-14 0:59 ` [Qemu-devel] [PATCH 6/7] block/stream: " John Snow
2017-12-14 8:50 ` Paolo Bonzini
2017-12-18 14:29 ` Stefan Hajnoczi
2017-12-14 0:59 ` [Qemu-devel] [PATCH 7/7] block/backup: " John Snow
2017-12-14 8:50 ` Paolo Bonzini
2017-12-18 14:29 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fad7ac35-e2be-a7b0-078c-4aa4c3dd2905@redhat.com \
--to=pbonzini@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).