qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Chris Laplante <chris@laplante.io>, Thomas Huth <thuth@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: Addition of qtest_irq_intercept_out_named, or modify qtest_irq_interrupt_out?
Date: Fri, 7 Jul 2023 10:04:30 +0200	[thread overview]
Message-ID: <fb1ebb07-6452-9ba1-f394-9b43a44a4d80@linaro.org> (raw)
In-Reply-To: <v4-CFRWoJDePdhYGwXmcoZ4pJoJVk37oEGjiSx0aN-3K4aBwDF3_5SVTlspGOZnwk9QA7ewsCyGgitkgaxtSLRiqe2euhsY1klbjIdCkHf8=@laplante.io>

Hi Chris,

On 7/7/23 00:10, Chris Laplante wrote:
> Hello all,
> 
> I have a test case that needs to intercept a named GPIO out interrupt. 
> qtest_irq_intercept_out doesn't support this currently. I would like to 
> send a patch to add this functionality. Does anyone have a preference if 
> I implement it is a new function (qtest_irq_intercept_out_named), vs add 
> the functionality to qtest_irq_intercept_out in the form of an optional 
> additional parameter?

qtest_irq_intercept_out() takes a QOM path argument. Whether it is
a named IRQ or not should be irrelevant at this layer.

IMO qtest_process_command() need to be improved to handle named IRQs,
see the "/* We don't support intercept of named GPIOs yet */" comment
from commit a5f54290ce ("qdev: Implement named GPIOs"). Few days later
commit 60a79016ae ("qtest/irq: Rework IRQ interception") improved the
support. Few is missing IMO.

Regards,

Phil.


  reply	other threads:[~2023-07-07  8:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06 22:10 Addition of qtest_irq_intercept_out_named, or modify qtest_irq_interrupt_out? Chris Laplante
2023-07-07  8:04 ` Philippe Mathieu-Daudé [this message]
2023-07-09 23:13   ` Chris Laplante

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb1ebb07-6452-9ba1-f394-9b43a44a4d80@linaro.org \
    --to=philmd@linaro.org \
    --cc=chris@laplante.io \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).