Addition of qtest_irq_intercept_out_named, or modify qtest_irq_interrupt_out?

Addition of qtest_irq_intercept_out_named, or modify qtest_irq_interrupt_out?

[Chris Laplante]

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

Hello all,

I have a test case that needs to intercept a named GPIO out interrupt. qtest_irq_intercept_out doesn't support this currently. I would like to send a patch to add this functionality. Does anyone have a preference if I implement it is a new function (qtest_irq_intercept_out_named), vs add the functionality to qtest_irq_intercept_out in the form of an optional additional parameter?

Thanks,
Chris

[-- Attachment #2: Type: text/html, Size: 1372 bytes --]

Re: Addition of qtest_irq_intercept_out_named, or modify qtest_irq_interrupt_out?

[Philippe Mathieu-Daudé]

Hi Chris,

On 7/7/23 00:10, Chris Laplante wrote:
> Hello all,
> 
> I have a test case that needs to intercept a named GPIO out interrupt. 
> qtest_irq_intercept_out doesn't support this currently. I would like to 
> send a patch to add this functionality. Does anyone have a preference if 
> I implement it is a new function (qtest_irq_intercept_out_named), vs add 
> the functionality to qtest_irq_intercept_out in the form of an optional 
> additional parameter?

qtest_irq_intercept_out() takes a QOM path argument. Whether it is
a named IRQ or not should be irrelevant at this layer.

IMO qtest_process_command() need to be improved to handle named IRQs,
see the "/* We don't support intercept of named GPIOs yet */" comment
from commit a5f54290ce ("qdev: Implement named GPIOs"). Few days later
commit 60a79016ae ("qtest/irq: Rework IRQ interception") improved the
support. Few is missing IMO.

Regards,

Phil.

Re: Addition of qtest_irq_intercept_out_named, or modify qtest_irq_interrupt_out?

[Chris Laplante]

[sorry, resending because I forgot to reply-all]

> qtest_irq_intercept_out() takes a QOM path argument. Whether it is
> a named IRQ or not should be irrelevant at this layer.

I'm a little confused about the QOM path. Currently the code in qtest_process_command() is calling object_resolve_path, but (as I understand it) a named IRQ is not an object, it's a property. So I either need to find a flavor of object_resolve_path that can also handle properties, or I need to add a parameter to qtest_irq_intercept_out for specifying the name. Does that sound right?

Thanks,
Chris