From: "andrzej zaborowski" <balrog@zabor.org>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] SecureDigital card emulation.
Date: Sat, 17 Mar 2007 12:01:31 +0100 [thread overview]
Message-ID: <fb249edb0703170401m790a296bp8e7a075493449aee@mail.gmail.com> (raw)
In-Reply-To: <200703171029.19713.paul@codesourcery.com>
Hi,
On 17/03/07, Paul Brook <paul@codesourcery.com> wrote:
> On Friday 16 March 2007 20:59, andrzej zaborowski wrote:
> > Emulates an SD card with the full command set (no SPI mode though).
> > Should be more or less compliant with version 1.10 specification.
>
> I suspect your code only works on x86. Specifically things like:
>
> > +struct sd_response_r1_s {
> > + uint8_t cmd;
> > + uint32_t status;
> > + uint8_t crc;
> > +};
>
> Will be a 12-byte struct on many hosts, and probably also breaks on big-endian
> hosts. AFAICS there's no way for the caller of sd_write_cmdline to figure out
> what type of response is returned (other than the length), so has to rely on
> doing a bitwise copy.
The card is supposed to return the type of response matching the
command that was issued, so the the caller does know the type and
doesn't do bitwise copy. If the card is broken and returns a different
response then we get garbage, exactly like on the actual hardware.
Regards,
Andrew
prev parent reply other threads:[~2007-03-17 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-16 20:59 [Qemu-devel] [PATCH] SecureDigital card emulation andrzej zaborowski
2007-03-17 10:29 ` Paul Brook
2007-03-17 11:01 ` andrzej zaborowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb249edb0703170401m790a296bp8e7a075493449aee@mail.gmail.com \
--to=balrog@zabor.org \
--cc=balrogg@gmail.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).