From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HYWnJ-0007mU-OW for qemu-devel@nongnu.org; Mon, 02 Apr 2007 20:22:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HYWnF-0007mI-Qx for qemu-devel@nongnu.org; Mon, 02 Apr 2007 20:22:40 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HYWnF-0007mF-Lx for qemu-devel@nongnu.org; Mon, 02 Apr 2007 20:22:37 -0400 Received: from wx-out-0506.google.com ([66.249.82.230]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HYWk9-0004Db-Qp for qemu-devel@nongnu.org; Mon, 02 Apr 2007 20:19:25 -0400 Received: by wx-out-0506.google.com with SMTP id i30so2302438wxd for ; Mon, 02 Apr 2007 17:19:25 -0700 (PDT) Message-ID: Date: Tue, 3 Apr 2007 02:19:24 +0200 From: "andrzej zaborowski" Sender: balrogg@gmail.com Subject: Re: [Qemu-devel] Re: [PATCH] VMware SVGA II emulation In-Reply-To: <20070402010956.GC29594@networkno.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070402010956.GC29594@networkno.de> Reply-To: balrogg@gmail.com, qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Thiemo Seufer Hi, On 02/04/07, Thiemo Seufer wrote: [..] > I left the sdl_copy bit out because it broke scrolling of a guest Linux > framebuffer in the moment it initialized its virtual consoles. Maybe > that's a bug in libsdl 1.2. Thanks for checking this. I didn't have any ideas as to what could be affecting the Cirrus VGA in the patch, but yes, the .dpy_copy is used in it. This is to remove two obsolete variables in vl.c that I have accidentally left in the patch and only noticed it in the commitdiff: --- a/vl.c +++ b/vl.c @@ -543,10 +543,6 @@ int kbd_mouse_is_absolute(void) return qemu_put_mouse_event_current->qemu_put_mouse_event_absolute; } -void (*kbd_mouse_set)(int x, int y, int on) = NULL; -void (*kbd_cursor_define)(int width, int height, int bpp, int hot_x, int hot_y, - uint8_t *image, uint8_t *mask) = NULL; - void do_info_mice(void) { QEMUPutMouseEntry *cursor; Cheers, Andrzej