From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IdZhR-0006Z3-Lp
	for qemu-devel@nongnu.org; Thu, 04 Oct 2007 19:01:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IdZhQ-0006Yk-7F
	for qemu-devel@nongnu.org; Thu, 04 Oct 2007 19:01:44 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IdZhQ-0006Yf-07
	for qemu-devel@nongnu.org; Thu, 04 Oct 2007 19:01:44 -0400
Received: from nf-out-0910.google.com ([64.233.182.190])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <balrogg@gmail.com>) id 1IdZhP-0003et-Jy
	for qemu-devel@nongnu.org; Thu, 04 Oct 2007 19:01:43 -0400
Received: by nf-out-0910.google.com with SMTP id 30so325547nfu
	for <qemu-devel@nongnu.org>; Thu, 04 Oct 2007 16:01:42 -0700 (PDT)
Message-ID: <fb249edb0710041601x43d64f55r29af71160a8335bf@mail.gmail.com>
Date: Fri, 5 Oct 2007 01:01:42 +0200
From: "andrzej zaborowski" <balrogg@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] USB Webcam Redirection
In-Reply-To: <64F9B87B6B770947A9F8391472E032160232DC17@ehost011-8.exch011.intermedia.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <64F9B87B6B770947A9F8391472E032160232DC17@ehost011-8.exch011.intermedia.net>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hi,

On 24/09/2007, Arnon Gilboa <arnon.gilboa@qumranet.com> wrote:
> Attached is an updated patch for supporting isochronous transfers in
> redirected host USB devices. The initial goal was supporting USB 1.1 Webcam.
> Tested on WinXP guest with several Webcams. Works on USB 1.1 Webcams, as
> well as most USB 2.0 Webcams (backward compatibility) on low resolutions.
> Some jitter is visible in the video stream, and it will be fixed.
>
> Notice USE_ASYNCIO, which defines whether to use signal based async io or
> polling for receiving urbs. Currently it is disabled, so polling is used,
> but it does not seem to affect the performance because it uses the
> non-blocking USBDEVFS_REAPURBNDELAY ioctl. In order to use the signal based
> async io, the patch to usb-uhci.c should be applied.
>
> The patch includes parts of previous patches posted in Qemu-devel:
> usb_host_update_interfaces (from
> qemu-0.9.0-usb-multi-configs.patch),
> usb_linux_update_endp_table (qemu-usb-host-async.patch) as well as some
> other lines of code.
>
> I am currently working on the ehci emulation for fully supporting USB 2.0
> isochronous devices.
>
> Waiting for your comments,

I pushed both patches into CVS, but I haven't tested it with any
devices with ISO endpoints yet, so please do. I made some identifiers
static and also removed the first qemu_free to avoid double freeing
in:

    ret = usb_linux_update_endp_table(dev);
    if (ret) {
        qemu_free(dev);
        goto fail;
    }
...
fail:
    if (dev)
        qemu_free(dev);

Regards