From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IkoFn-00026b-Bm for qemu-devel@nongnu.org; Wed, 24 Oct 2007 17:59:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IkoFl-00023X-Nd for qemu-devel@nongnu.org; Wed, 24 Oct 2007 17:59:06 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IkoFl-00023D-ET for qemu-devel@nongnu.org; Wed, 24 Oct 2007 17:59:05 -0400 Received: from nf-out-0910.google.com ([64.233.182.187]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IkoFk-000601-VH for qemu-devel@nongnu.org; Wed, 24 Oct 2007 17:59:05 -0400 Received: by nf-out-0910.google.com with SMTP id 30so343661nfu for ; Wed, 24 Oct 2007 14:59:03 -0700 (PDT) Message-ID: Date: Wed, 24 Oct 2007 23:59:03 +0200 From: "andrzej zaborowski" Subject: Re: [Qemu-devel] [Patch] set boot sequence from command line In-Reply-To: <20071024084611.GA10261@karma.qumranet.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20071024084611.GA10261@karma.qumranet.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 24/10/2007, Dan Kenigsberg wrote: > Real PCs try to boot from a CD, then try the hard drive, and finally go > to the network. And they let their owner change that order. With the difference that on real PCs this is controlled by the BIOS menu rather than a hardware switch, but the latter seems more convenient for qemu. > This patch lets Qemu do the same with "-boot dcn". > > I'll be happy to hear comments about it, > > Dan. > > diff --git a/hw/an5206.c b/hw/an5206.c > index 94ecccb..2134184 100644 > --- a/hw/an5206.c > +++ b/hw/an5206.c > @@ -27,7 +27,7 @@ void DMA_run (void) > > /* Board init. */ > > -static void an5206_init(int ram_size, int vga_ram_size, int boot_device, > +static void an5206_init(int ram_size, int vga_ram_size, char *boot_device, > DisplayState *ds, const char **fd_filename, int snapshot, > const char *kernel_filename, const char *kernel_cmdline, > const char *initrd_filename, const char *cpu_model) BTW, it may be a good idea to pass all these values (maybe except ds) as a single struct, for purely practical reasons. Regards