From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ImVvd-0000SO-SY for qemu-devel@nongnu.org; Mon, 29 Oct 2007 10:49:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ImVvc-0000Og-51 for qemu-devel@nongnu.org; Mon, 29 Oct 2007 10:49:21 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ImVvb-0000OG-UO for qemu-devel@nongnu.org; Mon, 29 Oct 2007 10:49:19 -0400 Received: from ug-out-1314.google.com ([66.249.92.175]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ImVvb-0001Yi-Kh for qemu-devel@nongnu.org; Mon, 29 Oct 2007 10:49:19 -0400 Received: by ug-out-1314.google.com with SMTP id m2so947331uge for ; Mon, 29 Oct 2007 07:49:18 -0700 (PDT) Message-ID: Date: Mon, 29 Oct 2007 15:49:18 +0100 From: "andrzej zaborowski" Subject: Re: [Qemu-devel] [PATCH 1/3] Add args to -cdrom to define where is connected the cdrom In-Reply-To: <20071029132525.GA7128@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <11936114152690-git-send-email-Laurent.Vivier@bull.net> <11936114153499-git-send-email-Laurent.Vivier@bull.net> <20071029132525.GA7128@redhat.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org On 29/10/2007, Daniel P. Berrange wrote: > On Sun, Oct 28, 2007 at 11:43:33PM +0100, Laurent.Vivier@bull.net wrote: > > From: Laurent Vivier > > > > This patch allows to define where is connected the CDROM device (bus, > > unit). > > It extends the "-cdrom" syntax to add these paramaters: > > > > -cdrom file[,if=type][,bus=n][,unit=m] > > > > where "type" defines the interface (by default, "ide") > > "n" defines the bus number (by default 1) > > "m" defines the unit number (by default 0) > > > Having a separately named arg just for CDROMs was always rather odd/unhelpful. > I'd suggest that we leave all the -hda,hdb,hdc,-cdrom,-fda,-fdb etc unchanged > and use the -disk for setting up all types of disks, floppys, cdroms, etc. It > would just require one extra field for the -disk arg: Sounds logical and I thought this was the plan. I also wouldn't mind having -sda, -sdb... following the intuitive naming based on linux /dev, but IIRC there were some people on the list who didn't like this idea. (I know /dev/sda doesn't have to be an SCSI disk on some recent systems, but it's still the most intuitive name for most users). Regards