From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1In3QU-0007jr-SO
	for qemu-devel@nongnu.org; Tue, 30 Oct 2007 22:35:26 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1In3QS-0007iq-Be
	for qemu-devel@nongnu.org; Tue, 30 Oct 2007 22:35:25 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1In3QS-0007in-5L
	for qemu-devel@nongnu.org; Tue, 30 Oct 2007 22:35:24 -0400
Received: from nf-out-0910.google.com ([64.233.182.188])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <balrogg@gmail.com>) id 1In3QR-0002tx-Je
	for qemu-devel@nongnu.org; Tue, 30 Oct 2007 22:35:23 -0400
Received: by nf-out-0910.google.com with SMTP id 30so1942849nfu
	for <qemu-devel@nongnu.org>; Tue, 30 Oct 2007 19:35:22 -0700 (PDT)
Message-ID: <fb249edb0710301935y5967dda3j23e5a09206dd758c@mail.gmail.com>
Date: Wed, 31 Oct 2007 03:35:21 +0100
From: "andrzej zaborowski" <balrogg@gmail.com>
Subject: Re: [Qemu-devel] qemu vl.c vl.h hw/an5206.c hw/etraxfs.c hw/inte...
In-Reply-To: <1193797260.16781.380.camel@rapid>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <E1In2mT-0000lo-2D@cvs.savannah.gnu.org>
	<1193797260.16781.380.camel@rapid>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "J. Mayer" <l_indien@magic.fr>
Cc: qemu-devel@nongnu.org

Hi,

On 31/10/2007, J. Mayer <l_indien@magic.fr> wrote:
>
> On Wed, 2007-10-31 at 01:54 +0000, Andrzej Zaborowski wrote:
> > CVSROOT:      /sources/qemu
> > Module name:  qemu
> > Changes by:   Andrzej Zaborowski <balrog>     07/10/31 01:54:05
> >
> > Modified files:
> >       .              : vl.c vl.h
> >       hw             : an5206.c etraxfs.c integratorcp.c mcf5208.c
> >                        mips_malta.c mips_mipssim.c mips_pica61.c
> >                        mips_r4k.c palm.c pc.c ppc405_boards.c
> >                        ppc_chrp.c ppc_oldworld.c ppc_prep.c r2d.c
> >                        realview.c shix.c spitz.c sun4m.c sun4u.c
> >                        versatilepb.c
> >
> > Log message:
> >       Set boot sequence from command line (Dan Kenigsberg).
>
> There have been remarks about this patch that have not been addressed
> (not even answered, in fact).  For example, the MAX_BOOT_DEVICES is set
> to 3 when more than 3 boot devices are possible to select (see the
> BOOTCHARS definition), which clearly shows the patch is not consistent.

I double-checked to make sure all remarks made on qemu-devel were
addressed, but I may have missed something. It was explained that the
default bios supports only three boot devices, on a second thought I
see how this may affect people using a non-default bios, but I guess 3
boot devices is better than only one that was possible without this
patch.

Feel free to revert if you see any issues.

> Furthermore, the patch breaks the coding style in some files (at least
> the ones I checked), which is weird.

I also tried to make sure that the original style in every file was
retained (i.e. I wrapped lines crossing 80 chars), but again I may
have missed something.

Regards