From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1It7rd-0005ep-C0
	for qemu-devel@nongnu.org; Fri, 16 Nov 2007 15:32:33 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1It7rY-0005XZ-Kh
	for qemu-devel@nongnu.org; Fri, 16 Nov 2007 15:32:32 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1It7rY-0005XQ-Cf
	for qemu-devel@nongnu.org; Fri, 16 Nov 2007 15:32:28 -0500
Received: from ug-out-1314.google.com ([66.249.92.169])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <balrogg@gmail.com>) id 1It7rX-0008Ua-Ep
	for qemu-devel@nongnu.org; Fri, 16 Nov 2007 15:32:27 -0500
Received: by ug-out-1314.google.com with SMTP id m2so666685uge
	for <qemu-devel@nongnu.org>; Fri, 16 Nov 2007 12:32:26 -0800 (PST)
Message-ID: <fb249edb0711161232m22a60a8cp1891bdf1dc115cd2@mail.gmail.com>
Date: Fri, 16 Nov 2007 21:32:26 +0100
From: "andrzej zaborowski" <balrogg@gmail.com>
Subject: Re: [Qemu-devel] RFC: fix for random Qemu crashes
In-Reply-To: <1195229132.28318.10.camel@jma4.dev.netgem.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1195168693.2415.19.camel@rapid>
	<200711161552.55645.paul@codesourcery.com>
	<1195229132.28318.10.camel@jma4.dev.netgem.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: l_indien@magic.fr, qemu-devel@nongnu.org
Cc: Paul Brook <paul@codesourcery.com>

On 16/11/2007, Jocelyn Mayer <l_indien@magic.fr> wrote:
>
> On Fri, 2007-11-16 at 15:52 +0000, Paul Brook wrote:
> > > Then, I choosed to replace 'inline' by 'always_inline', which is more
> > > invasive but have less risks of side effects. The diff is attached in
> > > always_inline.diff.
> > > The last thing that helps solve the problem is to change the inlining
> > > limits of gcc, at least to compile the op.o file.
> >
> > Presumably we only need one of the last two patches? It seems rather pointless
> > to have always_inline *and* change the inlining heuristics.
>
> >From the tests I made, it seems that adding always_inline helps but
> unfortunatelly does not solve all cases. Should check in the gcc source
> code why it is so...
>
> > I'm ok with using always_inline for op.o (and things it uses directly) as this
> > is required for correctness. I'm not convinced that that using always_inline
> > everywhere is such a good idea.
>
> That's exactly what I did: I changed 'inline' to 'always_inline' in
> headers that are included by op.c, I did not made any change in other
> headers.

I think a line like

#define inline __attribute__ (( always_inline )) inline

in dyngen-exec.h should be enough?

Regards