From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ItKNn-0005CA-Hg for qemu-devel@nongnu.org; Sat, 17 Nov 2007 04:54:35 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ItKNl-0005AC-W1 for qemu-devel@nongnu.org; Sat, 17 Nov 2007 04:54:35 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ItKNl-00059O-CT for qemu-devel@nongnu.org; Sat, 17 Nov 2007 04:54:33 -0500 Received: from ug-out-1314.google.com ([66.249.92.173]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ItKNk-0003Cd-UN for qemu-devel@nongnu.org; Sat, 17 Nov 2007 04:54:33 -0500 Received: by ug-out-1314.google.com with SMTP id m2so706270uge for ; Sat, 17 Nov 2007 01:54:32 -0800 (PST) Message-ID: Date: Sat, 17 Nov 2007 10:54:32 +0100 From: "andrzej zaborowski" Subject: Re: [Qemu-devel] [PATCH]bug fix for softmmu slow_st unaligned access In-Reply-To: <13502111.post@talk.nabble.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <13449885.post@talk.nabble.com> <13502111.post@talk.nabble.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi, On 31/10/2007, TeLeMan wrote: > If the 0x10008000 page is writable and 0x10007FFF isn't, softmmu can raise > this exception before modifing 0x10007FFF-0x10008002 because softmmu checks > 0x10007FFF at first. I don't know if reversing the order is an exact > solution,but its simple and working. Assuming that DATA_SIZE is less than page size, I think it is okay for a workaround, I committed it. It shows that permissions are checked two times for the first byte (0x10007ffff) but maybe that's okay since this is a slow access anyway. Regards