From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IzMKR-0002ok-Nm
	for qemu-devel@nongnu.org; Mon, 03 Dec 2007 20:12:03 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IzMKR-0002nm-1L
	for qemu-devel@nongnu.org; Mon, 03 Dec 2007 20:12:03 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IzMKQ-0002nR-RQ
	for qemu-devel@nongnu.org; Mon, 03 Dec 2007 20:12:02 -0500
Received: from ug-out-1314.google.com ([66.249.92.171])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <balrogg@gmail.com>) id 1IzMKQ-0004W3-M9
	for qemu-devel@nongnu.org; Mon, 03 Dec 2007 20:12:02 -0500
Received: by ug-out-1314.google.com with SMTP id m2so2483964uge
	for <qemu-devel@nongnu.org>; Mon, 03 Dec 2007 17:11:59 -0800 (PST)
Message-ID: <fb249edb0712031711y1d5e4bav33af85b8d9ee44a3@mail.gmail.com>
Date: Tue, 4 Dec 2007 02:11:59 +0100
From: "andrzej zaborowski" <balrogg@gmail.com>
Subject: Re: [Qemu-devel] qemu vl.c hw/omap.c
In-Reply-To: <200712040102.03664.paul@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <E1IzLMx-0004kd-3j@localhost.localdomain>
	<200712040102.03664.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

On 04/12/2007, Paul Brook <paul@codesourcery.com> wrote:
> > Log message:
> >       Always create an SD bdrv, so that PXA and OMAP boards can boot with
> >       no card inserted again.  Eventually SD, CDROM and floppy should all
> >       be registered conditionally depending on machine.
>
> This seems the wrong way to solve this problem. The SD emulation should be
> able to cope with no device being present.

The bdrv's represent the concept of "drive" rather than "media", and
also in the case the bdrv must be present whenever there is a SD slot,
not an SD card (so that monitor command change and eject can be used).
I agree that not all machines have an SD slot, as not all machines
have a cd-rom drive or floppy drive.

So this needs to be fixed but this commit was a quick fix for the
regression from the -drive patch.
Regards