From: "andrzej zaborowski" <balrogg@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Patch][Pxa2xx] Mainstone mmc support
Date: Sun, 9 Dec 2007 05:33:41 +0100 [thread overview]
Message-ID: <fb249edb0712082033k79bab7d5i6ab9dae5e758ed6f@mail.gmail.com> (raw)
In-Reply-To: <475B078E.7060809@kama-aina.net>
On 08/12/2007, Armin <akuster@kama-aina.net> wrote:
> Hello,
>
> Please consider this patch for inclusion.
>
> This adds MMC and the rest of the FPGA irq definitions for the Mainstone II
Why are both the write-protect and card-detect signals being connected
to one input? If one of the inputs doesn't exist then just pass NULL
for the parameter, and if they are supposed to be ORed or ANDed then
this needs to be done explicitely.
The way it is in the patch the input will randomly take the level of
one of the two signals.
Regards
next prev parent reply other threads:[~2007-12-09 4:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-08 21:07 [Qemu-devel] [Patch][Pxa2xx] Mainstone mmc support Armin
2007-12-09 4:33 ` andrzej zaborowski [this message]
2007-12-09 17:12 ` Armin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb249edb0712082033k79bab7d5i6ab9dae5e758ed6f@mail.gmail.com \
--to=balrogg@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).