From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J1DrO-0001Hy-3Z for qemu-devel@nongnu.org; Sat, 08 Dec 2007 23:33:46 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J1DrM-0001Fo-M6 for qemu-devel@nongnu.org; Sat, 08 Dec 2007 23:33:45 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J1DrM-0001Fa-Ha for qemu-devel@nongnu.org; Sat, 08 Dec 2007 23:33:44 -0500 Received: from ug-out-1314.google.com ([66.249.92.174]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J1DrL-0003Ss-Ls for qemu-devel@nongnu.org; Sat, 08 Dec 2007 23:33:44 -0500 Received: by ug-out-1314.google.com with SMTP id m2so1208033uge for ; Sat, 08 Dec 2007 20:33:41 -0800 (PST) Message-ID: Date: Sun, 9 Dec 2007 05:33:41 +0100 From: "andrzej zaborowski" Subject: Re: [Qemu-devel] [Patch][Pxa2xx] Mainstone mmc support In-Reply-To: <475B078E.7060809@kama-aina.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <475B078E.7060809@kama-aina.net> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 08/12/2007, Armin wrote: > Hello, > > Please consider this patch for inclusion. > > This adds MMC and the rest of the FPGA irq definitions for the Mainstone II Why are both the write-protect and card-detect signals being connected to one input? If one of the inputs doesn't exist then just pass NULL for the parameter, and if they are supposed to be ORed or ANDed then this needs to be done explicitely. The way it is in the patch the input will randomly take the level of one of the two signals. Regards