From: "andrzej zaborowski" <balrogg@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] saving/loading PCI irq related state
Date: Mon, 10 Dec 2007 00:58:29 +0100 [thread overview]
Message-ID: <fb249edb0712091558w193693faqbece7b34d07972@mail.gmail.com> (raw)
In-Reply-To: <474C8CB0.7010304@qumranet.com>
Hi,
On 27/11/2007, Uri Lublin <uril@qumranet.com> wrote:
> Hello,
>
> If one is not lucky he/she may lose PCI interrupts when saving and
> loading a VM.
> It seems PCI irq related state is not being saved.
> When this happens, the guest hangs/spins and the cpu usage of the
> process stays around 100%.
>
> Attached are three patches to fix this:
> 01 -- when saving/loading a pci device, save/load its irq_state
> 02 -- save/load PCI-Bus irq related state
> 03 -- save/load PCI-bridge (i440FX/PIIX3) irq related state
>
> There are two alternatives, both recalculate PCI irq related state upon
> loadvm instead of saving/loading it:
> (a) Make every PCI device DEV (e.g. rtl8139, ne2000, usb-uhci, etc) call
> its DEV_update_irq() from its state-load-function. or
> (b) Keep patch 01 and recalculate 02 and 03 by going over all
> PCI-devices on the specific Bus/Bridge.
I committed the three patches together but I changed the put/get
functions used to ones that don't assume on sizeof(int) == 4. Compile
tested only, please check if I've not screwed this up.
Regards
prev parent reply other threads:[~2007-12-09 23:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 21:31 [Qemu-devel] saving/loading PCI irq related state Uri Lublin
2007-12-09 23:58 ` andrzej zaborowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb249edb0712091558w193693faqbece7b34d07972@mail.gmail.com \
--to=balrogg@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).