From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1J1WTX-0007HN-O9
	for qemu-devel@nongnu.org; Sun, 09 Dec 2007 19:26:23 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1J1WTW-0007EO-3G
	for qemu-devel@nongnu.org; Sun, 09 Dec 2007 19:26:23 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1J1WTV-0007EF-VR
	for qemu-devel@nongnu.org; Sun, 09 Dec 2007 19:26:22 -0500
Received: from ug-out-1314.google.com ([66.249.92.169])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <balrogg@gmail.com>) id 1J1WTV-0002Tx-M4
	for qemu-devel@nongnu.org; Sun, 09 Dec 2007 19:26:21 -0500
Received: by ug-out-1314.google.com with SMTP id m2so1340169uge
	for <qemu-devel@nongnu.org>; Sun, 09 Dec 2007 16:26:21 -0800 (PST)
Message-ID: <fb249edb0712091626t6b743927l3825f99e5652b883@mail.gmail.com>
Date: Mon, 10 Dec 2007 01:26:19 +0100
From: "andrzej zaborowski" <balrogg@gmail.com>
Subject: Re: [Qemu-devel] [Patch][update] Mainstone re-org plus flash
In-Reply-To: <4753355C.1030003@kama-aina.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <474B89C0.2050007@kama-aina.net>
	<20071202045518.GB617@networkno.de> <4753355C.1030003@kama-aina.net>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 02/12/2007, Armin <akuster@kama-aina.net> wrote:
> Thiemo,
>
> Thiemo Seufer wrote:
> > Armin wrote:
> >
> >> Hello,
> >>
> >> This includes the previous Mainstone re-org patch I sent earlier plus flash
> >> support.
> >> This adds two 32MiB flash devices. Mounts from mtdblock2 on flash device 0
> >> fine at boot.
> >>
> >
> > I did some guesswork on the flash initialization to make it build with
> > Laurent's -disk patch. Please check if it is still correct.
> >
>
> works fine.

Note that both chips get mapped at the same offset in phys_ram_base,
I'm quite sure this is a bug and not intentional? It may corrupt data
if the OS reads from both chips. I wanted to convert mainstone.c to
use qemu_ram_alloc like other pxa boards but I want to make sure this
is not intentional.

The value of mainstone_rom indicates this too.
Regards