From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J2Db2-0002Ta-1I for qemu-devel@nongnu.org; Tue, 11 Dec 2007 17:29:00 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J2Day-0002N4-Ia for qemu-devel@nongnu.org; Tue, 11 Dec 2007 17:28:59 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J2Day-0002My-EM for qemu-devel@nongnu.org; Tue, 11 Dec 2007 17:28:56 -0500 Received: from ug-out-1314.google.com ([66.249.92.168]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J2Day-0007bs-Eq for qemu-devel@nongnu.org; Tue, 11 Dec 2007 17:28:56 -0500 Received: by ug-out-1314.google.com with SMTP id m2so427791uge.4 for ; Tue, 11 Dec 2007 14:28:55 -0800 (PST) Message-ID: Date: Tue, 11 Dec 2007 23:28:55 +0100 From: "andrzej zaborowski" Subject: Re: [Qemu-devel] [PATCH] Capture network traffic to a tcpdump file - updated In-Reply-To: <380128.17287.qm@web57002.mail.re3.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <380128.17287.qm@web57002.mail.re3.yahoo.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 10/12/2007, Balazs Attila-Mihaly (Cd-MaN) wrote: > Here goes v0.2 for my patch :-) > Changes > - now the option is a separate command line switch: > -net capture,vlan=2,file=test.pcap > - it is also available from the monitor > - added some more constants / defines to avoid repeating portions of the code Would it be possible to implement this as simply another vlan client that does the logging in it's fd_read callback? I think this would be cleaner, we would avoid the special case and an additional condition check in every qemu_send_packet(). Regards