From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J2JnF-0003SL-Sd for qemu-devel@nongnu.org; Wed, 12 Dec 2007 00:06:01 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J2JnE-0003Q5-Cm for qemu-devel@nongnu.org; Wed, 12 Dec 2007 00:06:01 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J2JnE-0003Pr-5h for qemu-devel@nongnu.org; Wed, 12 Dec 2007 00:06:00 -0500 Received: from ug-out-1314.google.com ([66.249.92.173]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J2JnD-0003io-KP for qemu-devel@nongnu.org; Wed, 12 Dec 2007 00:05:59 -0500 Received: by ug-out-1314.google.com with SMTP id m2so480410uge.4 for ; Tue, 11 Dec 2007 21:05:58 -0800 (PST) Message-ID: Date: Wed, 12 Dec 2007 06:05:58 +0100 From: "andrzej zaborowski" Subject: Re: [Qemu-devel] [Patch 1/2][PXA27x] initial keypad support In-Reply-To: <475F3D80.3080102@kama-aina.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <475F3D80.3080102@kama-aina.net> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi, On 12/12/2007, Armin wrote: > Here is an attempt to add PXA27x keypad support. It currently only > supports the matrix type interface. It still needs direct and > mulitswitch support added. > > Just wanted to get something out there for folks to pound on. > > Comment and feedback welcome. Here are some comments: * Several bits in KPC and KPREC should be reset on read. The IRQ should be reset when it becomes masked in KPC, and potentially asserted when it becomes unmasked. * It's wasteful to go through all keys in the 8x8 matrix on every event. It can be avoided easily by mapping qemu keycode to matrix position, rather than position to keycode, for example the PalmT|E matrix keypad does that. * Please convert the indentation in the file to use spaces, before considering for inclusion. * The bit definitions and pxa2xx_keypad_s struct are local to the keypad module so they shouldn't be in the header file exposed to the whole world. * Please set a copyright owner. Regarding mainstone keypad patch: * Probably not worth to stick the keymap in a file of its own since it is not shared between different machines - it's an integral part of mainstone. Thanks, Andrew