From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J3rmM-0004Wh-Md for qemu-devel@nongnu.org; Sun, 16 Dec 2007 06:35:30 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J3rmL-0004WJ-6g for qemu-devel@nongnu.org; Sun, 16 Dec 2007 06:35:30 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J3rmL-0004WG-12 for qemu-devel@nongnu.org; Sun, 16 Dec 2007 06:35:29 -0500 Received: from ug-out-1314.google.com ([66.249.92.168]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J3rmK-0004F6-GH for qemu-devel@nongnu.org; Sun, 16 Dec 2007 06:35:28 -0500 Received: by ug-out-1314.google.com with SMTP id m2so1482098uge.4 for ; Sun, 16 Dec 2007 03:35:24 -0800 (PST) Message-ID: Date: Sun, 16 Dec 2007 12:35:24 +0100 From: "andrzej zaborowski" Subject: Re: [Qemu-devel] [PATCH] ioemu/qemu vga: save and restore vram buffer (revised) In-Reply-To: <18271.51596.784485.518603@mariner.uk.xensource.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <18269.33299.414015.995882@mariner.uk.xensource.com> <18271.51596.784485.518603@mariner.uk.xensource.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: xen-devel@lists.xensource.com Hi, On 12/12/2007, Ian Jackson wrote: > The first one (stdvga-save-vram-update.patch) is against current > xen-unstable tip (which now includes my previous version) and should > be applied there. > > The second (stdvga-save-vram-take2.patch) is a fresh diff against the > same qemu as before and should be regarded as replacing my previous > submission. On a second look there's something else I don't understand. The vram window is in RAM in stdvga, it's inside phys_ram_base, and the entire chunk pointed to by phys_ram_base is saved in vl.c. It's also saved/loaded as one of the first things that are loaded so at the time stdvga resumes, the vram should already have the correct contents. Regards