From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JShaG-0002KC-EI for qemu-devel@nongnu.org; Fri, 22 Feb 2008 18:45:40 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JShaE-0002In-T3 for qemu-devel@nongnu.org; Fri, 22 Feb 2008 18:45:39 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JShaE-0002Ii-Ie for qemu-devel@nongnu.org; Fri, 22 Feb 2008 18:45:38 -0500 Received: from ug-out-1314.google.com ([66.249.92.175]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JShaE-0001rS-JT for qemu-devel@nongnu.org; Fri, 22 Feb 2008 18:45:38 -0500 Received: by ug-out-1314.google.com with SMTP id m2so26511uge.4 for ; Fri, 22 Feb 2008 15:45:37 -0800 (PST) Message-ID: Date: Sat, 23 Feb 2008 00:45:37 +0100 From: "andrzej zaborowski" In-Reply-To: <1203709210-23314-1-git-send-email-aliguori@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1203709210-23314-1-git-send-email-aliguori@us.ibm.com> Subject: [Qemu-devel] Re: [PATCH] Don't explicitly set BAR values for VMware VGA Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org On 22/02/2008, Anthony Liguori wrote: > Right now we set explict base addresses for the PCI IO regions in the VMware > VGA device. We don't register the second region at all and instead directly > map the physical memory. > > The problem is, the addresses we're setting in the BAR is not taken into > account in the e820 mapping. > > This patch removes the explicit BARs and registers the second region through > the normal PCI code. > > I've only tested with a Linux guest and the open source VMware VGA driver. I have a very similar patch on my HD but I haven't included it because it causes my testing Ms Windows install to stop detecting the card. I just tested your patch and the same thing happens, i.e. with the patch it works as a vga card but is detected as an Unknown adapter and only the 640x480x8 mode can be used. I can't explain this. Currently the io port numbers can be set by the guest and the memory io regions are fixed. Earlier both settings were hardcoded. This is because in one version of the X driver (which was/is the only documentation available) these settings were metioned as *the* correct values for this card. This may of course cause different types of breakage but so far worked ok, except when it was found that in various combinations qemu segfaulted due to different PCI cards registering the same port range as our default. When this happened I tried to make these settings settable through PCI registers but found that this broke Ms Windows. Luckily Ms Windows still worked if only port ranges were assigned dynamically and the segfault went away so I left it at this but it perhaps needs better looking at. -- Please do not print this email unless absolutely necessary. Spread environmental awareness.