From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JpCNp-0007u5-GZ
	for qemu-devel@nongnu.org; Thu, 24 Apr 2008 21:05:49 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JpCNo-0007tO-2l
	for qemu-devel@nongnu.org; Thu, 24 Apr 2008 21:05:49 -0400
Received: from [199.232.76.173] (port=41690 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JpCNn-0007tL-Vp
	for qemu-devel@nongnu.org; Thu, 24 Apr 2008 21:05:48 -0400
Received: from ug-out-1314.google.com ([66.249.92.170])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <balrogg@gmail.com>) id 1JpCNn-0000p9-H0
	for qemu-devel@nongnu.org; Thu, 24 Apr 2008 21:05:47 -0400
Received: by ug-out-1314.google.com with SMTP id m2so913441uge.4
	for <qemu-devel@nongnu.org>; Thu, 24 Apr 2008 18:05:46 -0700 (PDT)
Message-ID: <fb249edb0804241805q10ead6e5mc2edb7110a7b6a9b@mail.gmail.com>
Date: Fri, 25 Apr 2008 03:05:46 +0200
From: "andrzej zaborowski" <balrogg@gmail.com>
Subject: Re: [Qemu-devel] [4249] Improve audio api use in WM8750.
In-Reply-To: <48112992.2000602@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <E1Jp8ZZ-0002f6-Ha@cvs.savannah.gnu.org> <4810FBF9.1040308@web.de>
	<fb249edb0804241634q745bad0cpbce40f3087036f6a@mail.gmail.com>
	<48111E61.9050002@web.de> <4811213C.7020507@web.de>
	<fb249edb0804241723x748df377nc3f88e4b48536f4@mail.gmail.com>
	<48112992.2000602@web.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 25/04/2008, Jan Kiszka <jan.kiszka@web.de> wrote:
>  > The checking of whether the guest filled enough data happens in
>  > wm8750_dac_dat(), I don't see why do it second time here.  The only
>  > place we need an additional check is before s->dat_req call, which you
>  > remove.
>
> True, that's redundant, let's fix it this way (this even obsoletes the
>  flush in out_cb):

Ok, although I insist that it doesn't obsolete the check in out_cb
(hence why I added it).  Imagine s->req_out was 5000, and the guest
already wrote 1000 bytes. Now suddenly audio API calls out_cb with
free_b == 1500. In this case we have half of the buffer ready to
write, *before* we call s->data_req.

BTW I just committed a change to the MusicPal LCD, please check if it
still works.  Thanks.
-- 
Please do not print this email unless absolutely necessary. Spread
environmental awareness.