From: "andrzej zaborowski" <balrogg@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH] bdrv_flush error handling
Date: Sat, 26 Apr 2008 17:15:19 +0200 [thread overview]
Message-ID: <fb249edb0804260815s367c24acv56ae9998b4acdfd6@mail.gmail.com> (raw)
In-Reply-To: <18413.10389.596581.127047@mariner.uk.xensource.com>
On 28/03/2008, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:
> On the 20th of February I wrote:
> > bdrv_flush is declared to return void, but this is wrong because it
> > means that the implementations have nowhere to report their errors.
> > Indeed, the implementations generally ignore errors.
> >
> > This patch corrects this by making it return int (implicitly, either 0
> > or -errno, as for other similar functions). All of the
> > implementations and callers are adjusted too.
>
> There was some discussion which I think concluded that this change was
> good but the patch doesn't seem to have been applied.
It doesn't seem to apply against qemu, I could modify it but I don't
know how block-raw-win32.c reports errors.
Regards
next prev parent reply other threads:[~2008-04-26 15:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 15:53 [Qemu-devel] [PATCH] bdrv_flush error handling Ian Jackson
2008-02-20 16:04 ` Daniel P. Berrange
2008-02-20 16:13 ` Ian Jackson
2008-02-20 16:19 ` Paul Brook
2008-02-20 16:23 ` Avi Kivity
2008-02-20 16:37 ` Ian Jackson
2008-02-20 16:46 ` Paul Brook
2008-02-20 16:53 ` Ian Jackson
2008-02-20 16:31 ` Jamie Lokier
2008-02-20 18:17 ` Paul Brook
2008-02-20 16:38 ` Jamie Lokier
2008-02-20 18:22 ` Daniel P. Berrange
2008-02-20 19:01 ` Anthony Liguori
2008-02-20 19:55 ` Rick Vernam
2008-02-21 7:10 ` Thomas Irlet
2008-02-21 17:19 ` Ben Taylor
2008-02-21 17:24 ` Daniel P. Berrange
2008-02-21 17:28 ` risc
2008-02-21 18:24 ` Daniel P. Berrange
2008-03-28 17:19 ` [Qemu-devel] " Ian Jackson
2008-04-26 15:15 ` andrzej zaborowski [this message]
2008-04-29 16:27 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb249edb0804260815s367c24acv56ae9998b4acdfd6@mail.gmail.com \
--to=balrogg@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).