From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JsdNC-0008TC-TL for qemu-devel@nongnu.org; Sun, 04 May 2008 08:31:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JsdN8-0008SS-QU for qemu-devel@nongnu.org; Sun, 04 May 2008 08:31:20 -0400 Received: from [199.232.76.173] (port=47407 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JsdN8-0008SD-Aw for qemu-devel@nongnu.org; Sun, 04 May 2008 08:31:18 -0400 Received: from ug-out-1314.google.com ([66.249.92.172]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JsdN8-0003tR-1z for qemu-devel@nongnu.org; Sun, 04 May 2008 08:31:18 -0400 Received: by ug-out-1314.google.com with SMTP id m2so521378uge.4 for ; Sun, 04 May 2008 05:31:15 -0700 (PDT) Message-ID: Date: Sun, 4 May 2008 14:31:14 +0200 From: "andrzej zaborowski" Subject: Re: [Qemu-devel] [4321] First cut at WM8750 volume control (Jan Kiszka). In-Reply-To: <481D944E.7090703@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <481D944E.7090703@web.de> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 04/05/2008, Jan Kiszka wrote: > -#define NOVOL > +//#define NOVOL > > /* 8 bit */ > #define ENDIAN_CONVERSION natural > > to make the MusicPal work out-of-the-box (muting is now broken again, > causing loud noise during channel switches and while in suspended mode). Right, as I said you need to disable NOVOL manually if you want volume control. Changing this would affect users of all machines of all architectures and until now everyone was fine with using the host mixer instead of software mixing in qemu. BTW, I noticed that on some radio stations I get double speed playback, not sure what's causing this. My recent commit, while correct (I think), doesn't fix this. For a test case try connecting to: Internet Radio -> Countries -> Europe -> Spain -> All Stations -> Caroline International, the firmware sets both the WM8750 sample rate and the CPUs audio iface to 24 KHz but correct value is 12KHz or so. (I by no means recommend that station for listening). Also BTW, do you want to add a qemu-doc.texi piece describing -M musicpal? Otherwise I'll add something. Regards -- Please do not print this email unless absolutely necessary. Spread environmental awareness.