From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JxRGY-0002ov-5N
	for qemu-devel@nongnu.org; Sat, 17 May 2008 14:36:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JxRGV-0002oY-Ny
	for qemu-devel@nongnu.org; Sat, 17 May 2008 14:36:20 -0400
Received: from [199.232.76.173] (port=45566 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JxRGV-0002oV-LA
	for qemu-devel@nongnu.org; Sat, 17 May 2008 14:36:19 -0400
Received: from ug-out-1314.google.com ([66.249.92.170]:43621)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <balrogg@gmail.com>) id 1JxRGV-0000Ci-90
	for qemu-devel@nongnu.org; Sat, 17 May 2008 14:36:19 -0400
Received: by ug-out-1314.google.com with SMTP id j40so141339ugd.4
	for <qemu-devel@nongnu.org>; Sat, 17 May 2008 11:36:17 -0700 (PDT)
Message-ID: <fb249edb0805171136k57b9ce94me61f0499414363e2@mail.gmail.com>
Date: Sat, 17 May 2008 20:36:17 +0200
From: "andrzej zaborowski" <balrogg@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] serial save load fix
In-Reply-To: <482C6C78.6050708@virtualiron.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <482C6C78.6050708@virtualiron.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ben Guthro <bguthro@virtualiron.com>
Cc: Robert Phillips <rphillips@virtualiron.com>, qemu-devel@nongnu.org

On 15/05/2008, Ben Guthro <bguthro@virtualiron.com> wrote:
>  This patch fixes several bugs in serial.c
>  (1) No support provided in serial_load() for version_id == 1 (should
> unmarshal
>  a 1 byte s->divider and should provide a default value for s->fcr
>  (2) Call serial_ioport_write() to initialize s->fcr. It is not sufficient
>  to load its value; other hidden values (such as s->recv_fifo.itl) must be
>  re-initialized.

The patch does apply (other than it has to be de-HTML-ised) but
version 2 of serial_load doesn't save the FCR, at least in the SVN
tree, http://svn.savannah.gnu.org/viewvc/trunk/hw/serial.c?revision=4336&root=qemu&view=markup

Please check.

Cheers
-- 
Please do not print this email unless absolutely necessary. Spread
environmental awareness.