From: "andrzej zaborowski" <balrogg@gmail.com>
To: Ben Guthro <bguthro@virtualiron.com>
Cc: Robert Phillips <rphillips@virtualiron.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] serial save load fix
Date: Sat, 17 May 2008 20:37:08 +0200 [thread overview]
Message-ID: <fb249edb0805171137i52a09ee2le63ca2cd3575b941@mail.gmail.com> (raw)
In-Reply-To: <fb249edb0805171136k57b9ce94me61f0499414363e2@mail.gmail.com>
On 17/05/2008, andrzej zaborowski <balrogg@gmail.com> wrote:
> On 15/05/2008, Ben Guthro <bguthro@virtualiron.com> wrote:
> > This patch fixes several bugs in serial.c
> > (1) No support provided in serial_load() for version_id == 1 (should
> > unmarshal
> > a 1 byte s->divider and should provide a default value for s->fcr
> > (2) Call serial_ioport_write() to initialize s->fcr. It is not sufficient
> > to load its value; other hidden values (such as s->recv_fifo.itl) must be
> > re-initialized.
>
>
> The patch does apply (other than it has to be de-HTML-ised) but
> version 2 of serial_load doesn't save the FCR, at least in the SVN
Err, of serial_save.
prev parent reply other threads:[~2008-05-17 18:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 17:01 [Qemu-devel] [PATCH] serial save load fix Ben Guthro
2008-05-17 18:36 ` andrzej zaborowski
2008-05-17 18:37 ` andrzej zaborowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb249edb0805171137i52a09ee2le63ca2cd3575b941@mail.gmail.com \
--to=balrogg@gmail.com \
--cc=bguthro@virtualiron.com \
--cc=qemu-devel@nongnu.org \
--cc=rphillips@virtualiron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).