[Qemu-devel] Mouse click queue patch

[Qemu-devel] Mouse click queue patch

[Joao Luis Meloni Assirati]

Hello,

I am a qemu user and would like to recommend Stefano Stabellini's mouse click 
queue patch that can be found in

http://marc.info/?l=qemu-devel&m=120152164232624&w=2

I am using it with qemu 0.9.1, windows xp guest and linux host. IMO this patch 
should be merged to qemu. Before this patch, missed double clicks were 
common. Now I never miss any double click.

Regards,
João Luis Meloni Assirati.

Re: [Qemu-devel] Mouse click queue patch

[Ian Jackson]

Joao Luis Meloni Assirati writes ("[Qemu-devel] Mouse click queue
> patch"): I am a qemu user and would like to recommend Stefano
> Stabellini's mouse click queue patch that can be found in
> 
> http://marc.info/?l=qemu-devel&m=120152164232624&w=2

Sorry to throw spanners, but I have a different mouse queue patch in
preparation.  Xen's qemu has a version of this already; I was holding
off pushing it upstream until I had successfully tested some of the
results of my merge.

My patch is entirely in usb-hid.  It queues events, coalescing
adjacent events which don't contain any button changes so as to avoid
generating a huge queue.  It also manages to mostly unify the USB
tablet and mouse handling.

Ian.

Re: [Qemu-devel] Mouse click queue patch

[andrzej zaborowski]

On 22/05/2008, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:
> Joao Luis Meloni Assirati writes ("[Qemu-devel] Mouse click queue
>  > patch"): I am a qemu user and would like to recommend Stefano
>
> > Stabellini's mouse click queue patch that can be found in
>  >
>  > http://marc.info/?l=qemu-devel&m=120152164232624&w=2
>
>
> Sorry to throw spanners, but I have a different mouse queue patch in
>  preparation.  Xen's qemu has a version of this already; I was holding
>  off pushing it upstream until I had successfully tested some of the
>  results of my merge.
>
>  My patch is entirely in usb-hid.  It queues events, coalescing

Why should it be in usb-hid?  It is a generic issue.

Regards
-- 
Please do not print this email unless absolutely necessary. Spread
environmental awareness.

Re: [Qemu-devel] Mouse click queue patch

[Ian Jackson]

andrzej zaborowski writes ("Re: [Qemu-devel] Mouse click queue patch"):
> On 22/05/2008, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:
> >  My patch is entirely in usb-hid.  It queues events, coalescing
> 
> Why should it be in usb-hid?  It is a generic issue.

Good question.  Ultimately because the way the queue is read is very
intertwined with the limits on sizes in USB packets.

It would be quite feasible to split it up and have the rest not be in
usb-hid.  But if I do that, to avoid a great deal of unnecessary
to-ing and fro-ing, the little queue still wants to be a transparent
structure rather than an opaque one.

Ian.