From: "andrzej zaborowski" <balrogg@gmail.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [4640] Enable SD card on creation.
Date: Mon, 2 Jun 2008 15:43:56 +0200 [thread overview]
Message-ID: <fb249edb0806020643x37951247lcfd024a4343eb6f1@mail.gmail.com> (raw)
In-Reply-To: <200806021419.08543.paul@codesourcery.com>
On 02/06/2008, Paul Brook <paul@codesourcery.com> wrote:
> > void sd_enable(SDState *sd, int enable)
>
> This shouldn't exist to start with. It should be using a qemu_irq, like the
> other GPIO pins do, and probably wants to be implemented outside sd.c anyway.
Yes, that shouldn't be in sd.c. We should be able to create a number
of SD cards and "insert" and "eject" them from the slots using monitor
commands or a chipselect pin driven by guest.
I partially did this in svn.openmoko.org qemu where we have SDIO cards
using the same slots as SD.
The root misconception is of whether BlockDriverState represents the
drive or the media. In the cd-rom implementation the whole state
machine is in the drive and the media is just a piece of plastic. In
MMC/SD the removable card has the entire state machine in it and using
bdrv_is_inserted() makes no sense anymore.
--
Please do not print this email unless absolutely necessary. Spread
environmental awareness.
prev parent reply other threads:[~2008-06-02 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-02 0:55 [Qemu-devel] [4640] Enable SD card on creation Andrzej Zaborowski
2008-06-02 13:19 ` Paul Brook
2008-06-02 13:43 ` andrzej zaborowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb249edb0806020643x37951247lcfd024a4343eb6f1@mail.gmail.com \
--to=balrogg@gmail.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).