From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KK5s6-0002yU-UR for qemu-devel@nongnu.org; Sat, 19 Jul 2008 02:24:47 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KK5s5-0002xQ-QX for qemu-devel@nongnu.org; Sat, 19 Jul 2008 02:24:45 -0400 Received: from [199.232.76.173] (port=45623 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KK5s5-0002xI-Gy for qemu-devel@nongnu.org; Sat, 19 Jul 2008 02:24:45 -0400 Received: from an-out-0708.google.com ([209.85.132.251]:34473) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KK5s5-0002lS-G8 for qemu-devel@nongnu.org; Sat, 19 Jul 2008 02:24:45 -0400 Received: by an-out-0708.google.com with SMTP id d18so427286and.130 for ; Fri, 18 Jul 2008 23:24:44 -0700 (PDT) Message-ID: Date: Sat, 19 Jul 2008 08:24:44 +0200 From: "andrzej zaborowski" Subject: Re: [Qemu-devel] Re: [4875] Remove unintended dereference, kills a warning (Jan Kiszka). In-Reply-To: <487DEB2D.5040302@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 Content-Disposition: inline References: <761ea48b0807160530k59412f39p6ae0c90c2756fb58@mail.gmail.com> <487DEB2D.5040302@web.de> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org MjAwOC83LzE2IEphbiBLaXN6a2EgPGphbi5raXN6a2FAd2ViLmRlPjoKPiBMYXVyZW50IERlc25v Z3VlcyB3cm90ZToKPj4gT24gV2VkLCBKdWwgMTYsIDIwMDggYXQgMjowNCBQTSwgQW5kcmVhcyBT Y2h3YWIgPHNjaHdhYkBzdXNlLmRlPiB3cm90ZToKPj4+IEFuZHJ6ZWogWmFib3Jvd3NraSA8YmFs cm9nZ0BnbWFpbC5jb20+IHdyaXRlczoKPj4+Cj4+Pj4gIHZvaWQgT1BQUk9UTyBvcF90YXNiX3JO KHZvaWQpCj4+Pj4gIHsKPj4+PiAtICAgIGNvbmRfdCgqKGludDhfdCAqKSBlbnYtPmdyZWdzW1BB UkFNMV0gPT0gMCk7Cj4+Pj4gLSAgICAqKGludDhfdCAqKSBlbnYtPmdyZWdzW1BBUkFNMV0gfD0g MHg4MDsKPj4+PiArICAgIGNvbmRfdCgoZW52LT5ncmVnc1tQQVJBTTFdICYmIDB4ZmYpID09IDAp Owo+Pj4+ICsgICAgKihpbnQ4X3QgKikgJmVudi0+Z3JlZ3NbUEFSQU0xXSB8PSAweDgwOwo+Pj4g VGhhdCBkb2VzIG5vdCBtYWtlIGFueSBzZW5zZSBhdCBhbGwuICBUaGUgVEFTIGluc24gb3BlcmF0 ZXMgb24gbWVtb3J5LAo+Pj4gbm90IG9uIGEgcmVnaXN0ZXIgKGF0b21pYyBvcGVyYXRpb25zIG9u bHkgbWFrZSBzZW5zZSBvbiBtZW1vcnkgYW55d2F5KS4KPj4KPj4gU0g0IGRvY3VtZW50YXRpb24g c2F5cyB0aGlzOgo+Pgo+PiBUQVMuQiBAUm4KPj4gICAgICAgICAgIElmIChSbikgPSAwLCAxIOKG kiBULCBlbHNlIDAg4oaSIFQKPj4gICAgICAgICAgIDEg4oaSIE1TQiBvZiAoUm4pCj4+Cj4+IFNv IGluZGVlZCBpdCBsb29rcyBsaWtlIEphbiBhbmQgQW5kcnplaiBwYXRjaCBpcyB3cm9uZy4KPgo+ IEF0IGxlYXN0IHRoZSBhdWRpZW5jZSBpcyBmaW5hbGx5IGxpc3RlbmluZy4gOykKPgo+IElzIHRo aXMgb25lIGJldHRlcj8KCkkgc3VzcGVjdCBvbmUgb2YgdGhlc2UgbWF5IGJlIG1vcmUgY29ycmVj dCwgYnV0IEkgaGF2ZW4ndCBzZWVuIHRoZQpkb2NzLiAgVGhlIGJlbG93LCBsaWtlIHRoZSBvcmln aW5hbCB2ZXJzaW9uLCBhc3N1bWVzIHRoYXQgaWYgdGhlIHN0b3JlCmdlbmVyYXRlcyBzb21lIGtp bmQgb2YgdHJhcCwgdGhlIGZsYWcgaXMgc3RpbGwgYWZmZWN0ZWQuIE90aGVyd2lzZQpjb25kX3Qg bmVlZHMgdG8gYmUgdGhlIGxhc3QuCgpkaWZmIC0tZ2l0IGEvdGFyZ2V0LXNoNC9vcC5jIGIvdGFy Z2V0LXNoNC9vcC5jCi0tLSBhL3RhcmdldC1zaDQvb3AuYworKysgYi90YXJnZXQtc2g0L29wLmMK QEAgLTU5MiwxMyArNTkyLDYgQEAgdm9pZCBPUFBST1RPIG9wX3NobHIxNl9Sbih2b2lkKQogICAg IFJFVFVSTigpOwogfQoKLXZvaWQgT1BQUk9UTyBvcF90YXNiX3JOKHZvaWQpCi17Ci0gICAgY29u ZF90KChlbnYtPmdyZWdzW1BBUkFNMV0gJiAweGZmKSA9PSAwKTsKLSAgICAqKGludDhfdCAqKSAm ZW52LT5ncmVnc1tQQVJBTTFdIHw9IDB4ODA7Ci0gICAgUkVUVVJOKCk7Ci19Ci0KIHZvaWQgT1BQ Uk9UTyBvcF9tb3ZsX1QwX3JOKHZvaWQpCiB7CiAgICAgZW52LT5ncmVnc1tQQVJBTTFdID0gVDA7 CmRpZmYgLS1naXQgYS90YXJnZXQtc2g0L3RyYW5zbGF0ZS5jIGIvdGFyZ2V0LXNoNC90cmFuc2xh dGUuYwotLS0gYS90YXJnZXQtc2g0L3RyYW5zbGF0ZS5jCisrKyBiL3RhcmdldC1zaDQvdHJhbnNs YXRlLmMKQEAgLTEwNzcsNyArMTA3NywxMiBAQCB2b2lkIF9kZWNvZGVfb3BjKERpc2FzQ29udGV4 dCAqIGN0eCkKICAgICAgICBnZW5fb3Bfc2hscjE2X1JuKFJFRyhCMTFfOCkpOwogICAgICAgIHJl dHVybjsKICAgICBjYXNlIDB4NDAxYjogICAgICAgICAgICAgICAvKiB0YXMuYiBAUm4gKi8KLSAg ICAgICBnZW5fb3BfdGFzYl9yTihSRUcoQjExXzgpKTsKKyAgICAgICBnZW5fb3BfbW92bF9yTl9U MChSRUcoQjExXzgpKTsKKyAgICAgICBnZW5fb3BfbW92bF9UMF9UMSgpOworICAgICAgIGdlbl9v cF9sZHViX1QwX1QwKGN0eCk7CisgICAgICAgZ2VuX29wX2NtcF9lcV9pbW1fVDAoMCk7CisgICAg ICAgZ2VuX29wX29yX2ltbV9UMCgweDgwKTsKKyAgICAgICBnZW5fb3Bfc3RiX1QwX1QxKGN0eCk7 CiAgICAgICAgcmV0dXJuOwogICAgIGNhc2UgMHhmMDBkOiAvKiBmc3RzIEZQVUwsRlJuIC0gRlBT Q1I6IE5vdGhpbmcgKi8KICAgICAgICBnZW5fb3BfbW92bF9mcHVsX0ZUMCgpOwoKb3IKCmRpZmYg LS1naXQgYS90YXJnZXQtc2g0L29wLmMgYi90YXJnZXQtc2g0L29wLmMKLS0tIGEvdGFyZ2V0LXNo NC9vcC5jCisrKyBiL3RhcmdldC1zaDQvb3AuYwpAQCAtNTkyLDEzICs1OTIsNiBAQCB2b2lkIE9Q UFJPVE8gb3Bfc2hscjE2X1JuKHZvaWQpCiAgICAgUkVUVVJOKCk7CiB9Cgotdm9pZCBPUFBST1RP IG9wX3Rhc2Jfck4odm9pZCkKLXsKLSAgICBjb25kX3QoKGVudi0+Z3JlZ3NbUEFSQU0xXSAmIDB4 ZmYpID09IDApOwotICAgICooaW50OF90ICopICZlbnYtPmdyZWdzW1BBUkFNMV0gfD0gMHg4MDsK LSAgICBSRVRVUk4oKTsKLX0KLQogdm9pZCBPUFBST1RPIG9wX21vdmxfVDBfck4odm9pZCkKIHsK ICAgICBlbnYtPmdyZWdzW1BBUkFNMV0gPSBUMDsKZGlmZiAtLWdpdCBhL3RhcmdldC1zaDQvb3Bf bWVtLmMgYi90YXJnZXQtc2g0L29wX21lbS5jCi0tLSBhL3RhcmdldC1zaDQvb3BfbWVtLmMKKysr IGIvdGFyZ2V0LXNoNC9vcF9tZW0uYwpAQCAtNzYsMyArNzYsMTAgQEAgdm9pZCBnbHVlKG9wX3N0 ZnFfRFQwX1QxLCBNRU1TVUZGSVgpICh2b2lkKSB7CiAgICAgZ2x1ZShzdGZxLCBNRU1TVUZGSVgp IChUMSwgRFQwKTsKICAgICBSRVRVUk4oKTsKIH0KKwordm9pZCBnbHVlKG9wX3Rhc2JfUm4sIE1F TVNVRkZJWCkgKHZvaWQpIHsKKyAgICB1aW50OF90IHZhbCA9IGdsdWUobGR1YiwgTUVNU1VGRklY KSAoZW52LT5ncmVnc1tQQVJBTTFdKTsKKyAgICBjb25kX3QodmFsID09IDApOworICAgIGdsdWUo c3RiLCBNRU1TVUZGSVgpIChlbnYtPmdyZWdzW1BBUkFNMV0sIHZhbCB8IDB4ODApOworICAgIFJF VFVSTigpOworfQpkaWZmIC0tZ2l0IGEvdGFyZ2V0LXNoNC90cmFuc2xhdGUuYyBiL3RhcmdldC1z aDQvdHJhbnNsYXRlLmMKLS0tIGEvdGFyZ2V0LXNoNC90cmFuc2xhdGUuYworKysgYi90YXJnZXQt c2g0L3RyYW5zbGF0ZS5jCkBAIC04MCw2ICs4MCwxMCBAQCBzdGF0aWMgdm9pZCBzaDRfdHJhbnNs YXRlX2luaXQoKQogICAgIGdlbl9vcF9zdCMjd2lkdGgjI18jI3JlZyMjX1QxX3JhdygpOyBcCiAg IH0KCit2b2lkIGdlbl9vcF90YXNiX1JuKERpc2FzQ29udGV4dCAqY3R4LCBpbnQgcmVnKSB7Cisg ICAgZ2VuX29wX3Rhc2JfUm5fcmF3KHJlZyk7Cit9CisKICNlbHNlCgogI2RlZmluZSBHRU5fT1Bf TEQod2lkdGgsIHJlZykgXApAQCAtOTMsNiArOTcsMTMgQEAgc3RhdGljIHZvaWQgc2g0X3RyYW5z bGF0ZV9pbml0KCkKICAgICBlbHNlIGdlbl9vcF9zdCMjd2lkdGgjI18jI3JlZyMjX1QxX3VzZXIo KTtcCiAgIH0KCit2b2lkIGdlbl9vcF90YXNiX1JuKERpc2FzQ29udGV4dCAqY3R4LCBpbnQgcmVn KSB7CisgICAgaWYgKGN0eC0+bWVtaWR4KQorICAgICAgICBnZW5fb3BfdGFzYl9Sbl9rZXJuZWwo cmVnKTsKKyAgICBlbHNlCisgICAgICAgIGdlbl9vcF90YXNiX1JuX3VzZXIocmVnKTsKK30KKwog I2VuZGlmCgogR0VOX09QX0xEKHViLCBUMCkKQEAgLTEwNzcsNyArMTA4OCw3IEBAIHZvaWQgX2Rl Y29kZV9vcGMoRGlzYXNDb250ZXh0ICogY3R4KQogICAgICAgIGdlbl9vcF9zaGxyMTZfUm4oUkVH KEIxMV84KSk7CiAgICAgICAgcmV0dXJuOwogICAgIGNhc2UgMHg0MDFiOiAgICAgICAgICAgICAg IC8qIHRhcy5iIEBSbiAqLwotICAgICAgIGdlbl9vcF90YXNiX3JOKFJFRyhCMTFfOCkpOworICAg ICAgIGdlbl9vcF90YXNiX1JuKGN0eCwgUkVHKEIxMV84KSk7CiAgICAgICAgcmV0dXJuOwogICAg IGNhc2UgMHhmMDBkOiAvKiBmc3RzIEZQVUwsRlJuIC0gRlBTQ1I6IE5vdGhpbmcgKi8KICAgICAg ICBnZW5fb3BfbW92bF9mcHVsX0ZUMCgpOwo=