From: "andrzej zaborowski" <balrogg@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] target arm fstat64 bug
Date: Sat, 19 Jul 2008 11:49:48 +0200 [thread overview]
Message-ID: <fb249edb0807190249r5b9f5f93x4562a109f1824b29@mail.gmail.com> (raw)
In-Reply-To: <loom.20080716T203556-537@post.gmane.org>
2008/7/16 matthieu castet <castet.matthieu@free.fr>:
> Hi,
>
> it seems there a problem with fstat64 struct. __pad2 should be 4 not 8 :
> before it was :
> unsigned short st_rdev;
> unsigned char __pad3[10];
> now sizeof st_rdev = 8, so we take 6 bytes to __pad3.
> This match linux kernel declaration.
>
> Index: linux-user/syscall_defs.h
> ===================================================================
> --- linux-user/syscall_defs.h (revision 4881)
> +++ linux-user/syscall_defs.h (working copy)
> @@ -962,7 +962,7 @@
> abi_ulong st_gid;
>
> unsigned long long st_rdev;
> - unsigned int __pad2[2];
> + unsigned int __pad2;
Is it ok to use int here at all? Also in the kernel I'm looking at
there's no padding between .st_blksize and .st_blocks.
Regards
prev parent reply other threads:[~2008-07-19 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 20:39 [Qemu-devel] target arm fstat64 bug matthieu castet
2008-07-19 8:39 ` [Qemu-devel] " matthieu castet
2008-07-19 9:49 ` andrzej zaborowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb249edb0807190249r5b9f5f93x4562a109f1824b29@mail.gmail.com \
--to=balrogg@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).