From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KK94c-0007WS-6M for qemu-devel@nongnu.org; Sat, 19 Jul 2008 05:49:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KK94Y-0007Or-2v for qemu-devel@nongnu.org; Sat, 19 Jul 2008 05:49:51 -0400 Received: from [199.232.76.173] (port=43389 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KK94X-0007OT-Rv for qemu-devel@nongnu.org; Sat, 19 Jul 2008 05:49:49 -0400 Received: from an-out-0708.google.com ([209.85.132.245]:56416) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KK94X-0001Wo-HE for qemu-devel@nongnu.org; Sat, 19 Jul 2008 05:49:49 -0400 Received: by an-out-0708.google.com with SMTP id d18so436022and.130 for ; Sat, 19 Jul 2008 02:49:49 -0700 (PDT) Message-ID: Date: Sat, 19 Jul 2008 11:49:48 +0200 From: "andrzej zaborowski" Subject: Re: [Qemu-devel] target arm fstat64 bug In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org 2008/7/16 matthieu castet : > Hi, > > it seems there a problem with fstat64 struct. __pad2 should be 4 not 8 : > before it was : > unsigned short st_rdev; > unsigned char __pad3[10]; > now sizeof st_rdev = 8, so we take 6 bytes to __pad3. > This match linux kernel declaration. > > Index: linux-user/syscall_defs.h > =================================================================== > --- linux-user/syscall_defs.h (revision 4881) > +++ linux-user/syscall_defs.h (working copy) > @@ -962,7 +962,7 @@ > abi_ulong st_gid; > > unsigned long long st_rdev; > - unsigned int __pad2[2]; > + unsigned int __pad2; Is it ok to use int here at all? Also in the kernel I'm looking at there's no padding between .st_blksize and .st_blocks. Regards