qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "andrzej zaborowski" <balrogg@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 6/6] kvm: qemu: fix vga screendump
Date: Sun, 20 Jul 2008 19:07:10 +0200	[thread overview]
Message-ID: <fb249edb0807201007s177f8a18x30f19db4ab61080c@mail.gmail.com> (raw)
In-Reply-To: <4882A407.5060004@codemonkey.ws>

2008/7/20 Anthony Liguori <anthony@codemonkey.ws>:
> andrzej zaborowski wrote:
>>
>> 2008/7/17 Anthony Liguori <aliguori@us.ibm.com>:
>>
>>>
>>> From: Avi Kivity <avi@qumranet.com>
>>> Commit 737d2050 ("Implement resolution switching in common console code")
>>> uses qemu_console_resize() instead of dpy_resize().  This means
>>> console->ds
>>> is examined instead of the VGA private ds, and the resize does not take
>>> place,
>>> leading to a segfault.
>>>
>>> Fix by modifying the DisplayState directly rather than swapping the
>>> pointer.
>>>
>>
>> The screen dumping is hacky but maybe it's a good idea to keep the
>> hacks local to hw/vga.c, with something like the following diff.  I
>> think we need to fix the screen dumping globally (some graphic cards
>> will need fixing too).
>>
>
> I agree the screen dumping is pretty hacky right now.  Instead of installing
> a new DisplayState, I've never understood why we can't just dump ds->data
> after an appropriate translation.

With -no-graphic there's no ds->data, or it can have lower bpp than
what's otherwise available.

>
> I think your patch looks better, but I can also code up a new screen dumping
> mechanism that doesn't take over DisplayState unless I'm missing something
> obvious.

It's worth a try, dumping ds->data is perhaps the way to go but
ds->depth is being set to 32bit and various video cards are optimised
on the assumption that ds->depth doesn't change, so maybe there should
be a notification callback.

Regards

  reply	other threads:[~2008-07-20 17:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-17 21:19 [Qemu-devel] [PATCH 1/6] kvm: qemu: fix screendump with multiple consoles Anthony Liguori
2008-07-17 21:19 ` [Qemu-devel] [PATCH 2/6] kvm: qemu: force screen resize if a display buffer does not exist Anthony Liguori
2008-07-17 21:19 ` [Qemu-devel] [PATCH 3/6] kvm: qemu: revert "fix power management timer overflow handling" Anthony Liguori
2008-07-17 21:19 ` [Qemu-devel] [PATCH 4/6] kvm: qemu: revert ""QEMU keyboard issue with Gujin-2.2", by Etienne Lorrain." Anthony Liguori
2008-07-17 21:43   ` Even Rouault
2008-07-17 21:47   ` [Qemu-devel] " Jan Kiszka
2008-07-17 21:58     ` Anthony Liguori
2008-07-17 21:19 ` [Qemu-devel] [PATCH 5/6] kvm: qemu: improve scsi dma speed by increasing the dma buffer size Anthony Liguori
2008-07-20  2:37   ` Anthony Liguori
2008-07-17 21:19 ` [Qemu-devel] [PATCH 6/6] kvm: qemu: fix vga screendump Anthony Liguori
2008-07-19 14:36   ` andrzej zaborowski
2008-07-20  2:33     ` Anthony Liguori
2008-07-20 17:07       ` andrzej zaborowski [this message]
2008-07-20 18:39         ` Anthony Liguori
2008-07-20 19:28           ` andrzej zaborowski
2008-07-20 19:46             ` Anthony Liguori
2008-07-20 20:08               ` andrzej zaborowski
2008-07-20 21:53                 ` Anthony Liguori
2008-07-20 21:56                 ` Anthony Liguori
2008-07-21  2:00                   ` Jamie Lokier
2008-07-17 21:39 ` [Qemu-devel] [PATCH 0/6] Various fixes from KVM tree Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb249edb0807201007s177f8a18x30f19db4ab61080c@mail.gmail.com \
    --to=balrogg@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).