From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KKeaX-00085z-Sm for qemu-devel@nongnu.org; Sun, 20 Jul 2008 15:28:57 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KKeaW-00084s-EB for qemu-devel@nongnu.org; Sun, 20 Jul 2008 15:28:57 -0400 Received: from [199.232.76.173] (port=54678 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KKeaW-00084p-8h for qemu-devel@nongnu.org; Sun, 20 Jul 2008 15:28:56 -0400 Received: from an-out-0708.google.com ([209.85.132.246]:24046) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KKeaW-0004qa-4v for qemu-devel@nongnu.org; Sun, 20 Jul 2008 15:28:56 -0400 Received: by an-out-0708.google.com with SMTP id d18so546297and.130 for ; Sun, 20 Jul 2008 12:28:55 -0700 (PDT) Message-ID: Date: Sun, 20 Jul 2008 21:28:55 +0200 From: "andrzej zaborowski" Subject: Re: [Qemu-devel] [PATCH 6/6] kvm: qemu: fix vga screendump In-Reply-To: <4883867B.5000000@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1216329580-20804-1-git-send-email-aliguori@us.ibm.com> <1216329580-20804-6-git-send-email-aliguori@us.ibm.com> <4882A407.5060004@codemonkey.ws> <4883867B.5000000@codemonkey.ws> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org 2008/7/20 Anthony Liguori : > andrzej zaborowski wrote: >> >> 2008/7/20 Anthony Liguori : >> With -no-graphic there's no ds->data, or it can have lower bpp than >> what's otherwise available. >> > > Screen dumping with -no-graphic probably should just show a black screen > anyway. I thought this was the main use case. You shouldn't need sdl installed to perform the tests Avi talked about. > > I don't think a lower depth is really that big of a deal. It's what the > user would be seeing anyway. The simplicity seems really nice to me. > >>> I think your patch looks better, but I can also code up a new screen >>> dumping >>> mechanism that doesn't take over DisplayState unless I'm missing >>> something >>> obvious. >>> >> >> It's worth a try, dumping ds->data is perhaps the way to go but >> ds->depth is being set to 32bit and various video cards are optimised >> on the assumption that ds->depth doesn't change, so maybe there should >> be a notification callback. >> > > Yeah, that's a bug BTW and AFAIK it's only a problem with VMware VGA. AFAIK also at least three other adapters. > There's nothing that keeps ds->depth from changing after a screen resize > with SDL. If a VNC client does SetPixelFormat that will also change > ds->depth. Right now, some VNC clients + VMware VGA will cause a SEGV > because of the assumptions that ds->depth doesn't change. > > Regards, > > Anthony Liguori > >> Regards >> >> >> > > > >