qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "andrzej zaborowski" <balrogg@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add Apollon (OMAP24xx) board support
Date: Fri, 25 Jul 2008 11:13:13 +0200	[thread overview]
Message-ID: <fb249edb0807250213y1dc1574coa18570f006649d01@mail.gmail.com> (raw)
In-Reply-To: <fb249edb0807250115r1a468d17v87c3b8c926e0b1da@mail.gmail.com>

2008/7/25 andrzej zaborowski <balrogg@gmail.com>:
> 2008/7/25 Kyungmin Park <kmpark@infradead.org>:
>>>> @@ -3875,7 +3926,11 @@ static uint32_t omap_sdrc_read(void *opaque, target_phys_addr_t addr)
>>>>     case 0x68: /* SDRC_DLLB_CTRL */
>>>>     case 0x6c: /* SDRC_DLLB_STATUS */
>>>>     case 0x70: /* SDRC_POWER */
>>>> +         return 0x00;
>>>> +
>>>>     case 0x80: /* SDRC_MCFG_0 */
>>>> +         return 0x4000;
>>>> +
>>>
>>> This should be made writable (default value is 0) and the bootloader
>>> or the board file (hw/nseries.c) needs to write the correct value
>>> there.
>>
>> Agreed, apollon and omap2420h4 read this value at bootloader, Yes it's
>> meanless in qemu.
>> it's seted at initial bootloader, but it's not in qemu. If sdrc has
>> array value, we can read it
>
> I mean something like
>
>    uint32_t mcfg0 = (boot_info.ram_size / 0x200000) << 8;        /* RAMSIZE */
>
>    cpu_physical_memory_write(0x68009080,     /* SDRC_MCFG_0 */
>                    (void *) &mcfg0, sizeof(mcfg0));

Actually it's set to half the ram size in SDRC_MCFG_0 and other half
in SDRC_MCFG_1 because there are two chips. Nokia bootloader writes
the following values:

0x01702019 in 0x68009080 and
0x01702019 in 0x680090b0

Cheers

  reply	other threads:[~2008-07-25  9:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-24 23:00 [Qemu-devel] [PATCH] Add Apollon (OMAP24xx) board support Kyungmin Park
2008-07-25  7:18 ` andrzej zaborowski
2008-07-25  7:54   ` Kyungmin Park
2008-07-25  8:15     ` andrzej zaborowski
2008-07-25  9:13       ` andrzej zaborowski [this message]
2008-07-28  7:09       ` Kyungmin Park
  -- strict thread matches above, loose matches on Subject: below --
2008-07-23 23:34 Kyungmin Park
2008-07-24  8:45 ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb249edb0807250213y1dc1574coa18570f006649d01@mail.gmail.com \
    --to=balrogg@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).