From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KNpkB-0003hN-LF for qemu-devel@nongnu.org; Tue, 29 Jul 2008 10:00:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KNpk8-0003gf-SN for qemu-devel@nongnu.org; Tue, 29 Jul 2008 10:00:02 -0400 Received: from [199.232.76.173] (port=46475 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KNpk8-0003gW-Oc for qemu-devel@nongnu.org; Tue, 29 Jul 2008 10:00:00 -0400 Received: from wr-out-0506.google.com ([64.233.184.227]:50196) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KNpk8-000420-GN for qemu-devel@nongnu.org; Tue, 29 Jul 2008 10:00:00 -0400 Received: by wr-out-0506.google.com with SMTP id c46so4438860wra.18 for ; Tue, 29 Jul 2008 06:59:59 -0700 (PDT) Message-ID: Date: Tue, 29 Jul 2008 15:59:58 +0200 From: "andrzej zaborowski" Subject: Re: [Qemu-devel] [PATCH]: Fix i2c_bus_save, which fixes KVM live migration In-Reply-To: <488EBEFC.5040603@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <488EBEFC.5040603@redhat.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kvm@vger.kernel.org 2008/7/29 Chris Lalancette : > Attached is a simple patch to make i2c_bus_save() put a 32-bit quantity in the > save file, which matches what i2c_bus_load() expects to pull out of the save > file later. Without this fix in place, KVM live migration fails since the > sender is only sending 1 byte while the receiver is waiting to receive 4 bytes. Thanks, I committed this modified to use byte width afterall since the addresses are 7-bit quantities, as noted by Anthony. Means that existing snapshots are not invalidated. Cheers