From: "andrzej zaborowski" <balrogg@gmail.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH]: Fix i2c_bus_save, which fixes KVM live migration
Date: Tue, 29 Jul 2008 20:35:58 +0200 [thread overview]
Message-ID: <fb249edb0807291135u64fbc9efh513622f1c74239ce@mail.gmail.com> (raw)
In-Reply-To: <200807291918.55451.paul@codesourcery.com>
2008/7/29 Paul Brook <paul@codesourcery.com>:
> On Tuesday 29 July 2008, andrzej zaborowski wrote:
>> 2008/7/29 Chris Lalancette <clalance@redhat.com>:
>> > Attached is a simple patch to make i2c_bus_save() put a 32-bit quantity
>> > in the save file, which matches what i2c_bus_load() expects to pull out
>> > of the save file later. Without this fix in place, KVM live migration
>> > fails since the sender is only sending 1 byte while the receiver is
>> > waiting to receive 4 bytes.
>>
>> Thanks, I committed this modified to use byte width afterall since the
>> addresses are 7-bit quantities.
>
> No they aren't. I2C also supports 10-bit addressing.
Addresses in qemu are still <= 8-bit, for example i2c_slave_load()
assumes this and current i2c api users do.
Regards
next prev parent reply other threads:[~2008-07-29 18:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 6:55 [Qemu-devel] [PATCH]: Fix i2c_bus_save, which fixes KVM live migration Chris Lalancette
2008-07-29 13:06 ` [Qemu-devel] " Avi Kivity
2008-07-29 13:43 ` [Qemu-devel] " Anthony Liguori
2008-07-29 13:59 ` andrzej zaborowski
2008-07-29 18:18 ` Paul Brook
2008-07-29 18:35 ` andrzej zaborowski [this message]
2008-07-29 18:38 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb249edb0807291135u64fbc9efh513622f1c74239ce@mail.gmail.com \
--to=balrogg@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).