From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KNu3F-00041L-Ht
	for qemu-devel@nongnu.org; Tue, 29 Jul 2008 14:36:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KNu3E-00040g-3l
	for qemu-devel@nongnu.org; Tue, 29 Jul 2008 14:36:01 -0400
Received: from [199.232.76.173] (port=56037 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KNu3D-00040b-Rf
	for qemu-devel@nongnu.org; Tue, 29 Jul 2008 14:35:59 -0400
Received: from an-out-0708.google.com ([209.85.132.251]:30582)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <balrogg@gmail.com>) id 1KNu3D-0001eS-JB
	for qemu-devel@nongnu.org; Tue, 29 Jul 2008 14:35:59 -0400
Received: by an-out-0708.google.com with SMTP id d18so1859135and.130
	for <qemu-devel@nongnu.org>; Tue, 29 Jul 2008 11:35:59 -0700 (PDT)
Message-ID: <fb249edb0807291135u64fbc9efh513622f1c74239ce@mail.gmail.com>
Date: Tue, 29 Jul 2008 20:35:58 +0200
From: "andrzej zaborowski" <balrogg@gmail.com>
Subject: Re: [Qemu-devel] [PATCH]: Fix i2c_bus_save,
	which fixes KVM live migration
In-Reply-To: <200807291918.55451.paul@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <488EBEFC.5040603@redhat.com>
	<fb249edb0807290659s2eaa6f45ue02abe5907f22128@mail.gmail.com>
	<200807291918.55451.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

2008/7/29 Paul Brook <paul@codesourcery.com>:
> On Tuesday 29 July 2008, andrzej zaborowski wrote:
>> 2008/7/29 Chris Lalancette <clalance@redhat.com>:
>> > Attached is a simple patch to make i2c_bus_save() put a 32-bit quantity
>> > in the save file, which matches what i2c_bus_load() expects to pull out
>> > of the save file later.  Without this fix in place, KVM live migration
>> > fails since the sender is only sending 1 byte while the receiver is
>> > waiting to receive 4 bytes.
>>
>> Thanks, I committed this modified to use byte width afterall since the
>> addresses are 7-bit quantities.
>
> No they aren't. I2C also supports 10-bit addressing.

Addresses in qemu are still <= 8-bit, for example i2c_slave_load()
assumes this and current i2c api users do.

Regards