From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KfHFS-0003NT-Nj for qemu-devel@nongnu.org; Mon, 15 Sep 2008 12:48:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KfHFQ-0003M8-SB for qemu-devel@nongnu.org; Mon, 15 Sep 2008 12:48:25 -0400 Received: from [199.232.76.173] (port=44227 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KfHFQ-0003Lx-Cq for qemu-devel@nongnu.org; Mon, 15 Sep 2008 12:48:24 -0400 Received: from wf-out-1314.google.com ([209.85.200.172]:28879) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KfHFP-0005pt-PT for qemu-devel@nongnu.org; Mon, 15 Sep 2008 12:48:24 -0400 Received: by wf-out-1314.google.com with SMTP id 27so2115552wfd.4 for ; Mon, 15 Sep 2008 09:48:17 -0700 (PDT) Message-ID: Date: Mon, 15 Sep 2008 18:48:17 +0200 From: "andrzej zaborowski" Subject: Re: [Qemu-devel] [PATCH 1/1][RESEND] v2: Fix text console size/resize when using curses In-Reply-To: <1220544638-1972-2-git-send-email-ryanh@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1220544638-1972-1-git-send-email-ryanh@us.ibm.com> <1220544638-1972-2-git-send-email-ryanh@us.ibm.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Ryan Harper , Paul Brook , kvm@vger.kernel.org, Ian Kirk Hi, 2008/9/4 Ryan Harper : > v2: drop initial size adjustment, not needed. > > Resize events fail to ensure that both the text console and curses display areas > are the same size; this causes broken output like: It seems that this was broken by r4812. Your patch looks correct but I think it will prevent things like -serial vc:80Cx24C from working as documented. There's a conflict here: either virtual consoles have commandline-set fixed size or they adjust to the window size like before r4812 and don't have parts that don't fit on the screen. The SDL window is not resizable but the curses window is always resizable. I propose to add TEXT_CONSOLE_FIXED_SIZE back, it was removed by r4812. I will do this unless there are better ideas. Another idea would be to set the default console size to 640x400 and agree to not support terminals < 80x24. Regards