From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kh2tO-00082q-Fd for qemu-devel@nongnu.org; Sat, 20 Sep 2008 09:52:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kh2tM-00080j-PU for qemu-devel@nongnu.org; Sat, 20 Sep 2008 09:52:58 -0400 Received: from [199.232.76.173] (port=53628 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kh2tM-00080Z-GY for qemu-devel@nongnu.org; Sat, 20 Sep 2008 09:52:56 -0400 Received: from rv-out-0708.google.com ([209.85.198.242]:45374) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kh2tM-0006se-Aa for qemu-devel@nongnu.org; Sat, 20 Sep 2008 09:52:56 -0400 Received: by rv-out-0708.google.com with SMTP id f25so729825rvb.22 for ; Sat, 20 Sep 2008 06:52:55 -0700 (PDT) Message-ID: Date: Sat, 20 Sep 2008 15:52:55 +0200 From: "andrzej zaborowski" Subject: Re: [Qemu-devel] [PATCH] Fix vfork() syscall emulation In-Reply-To: <20080920131134.GA26850@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1221750426-14863-1-git-send-email-kirill@shutemov.name> <20080920064556.GA24679@localhost.localdomain> <20080920131134.GA26850@localhost.localdomain> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Kirill A. Shutemov" Cc: qemu-devel@nongnu.org, Paul Brook 2008/9/20 Kirill A. Shutemov : > So, implementation vfork() using pthread is wrong. Agreed, but implementation of vfork() using fork() is wrong, too. If we allow a hack, it should be commented, the second thing that needs to be commented is why the value of CLONE_VM flag is ignored if CLONE_VFORK is set -- on Linux it's not ignored. Cheers