From: "andrzej zaborowski" <balrogg@gmail.com>
To: qemu-devel@nongnu.org
Cc: Jan Niehusmann <jan@gondor.com>, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] Re: [Patch] Segfault with -vnc option
Date: Mon, 22 Sep 2008 23:15:04 +0200 [thread overview]
Message-ID: <fb249edb0809221415j72203436ka786b9b97db78ee5@mail.gmail.com> (raw)
In-Reply-To: <48D7DF10.4030004@codemonkey.ws>
2008/9/22 Anthony Liguori <anthony@codemonkey.ws>:
> Jan Niehusmann wrote:
>>
>> Hi!
>>
>
> Hi Jan,
>
> Very good catch. My only suggestion would be to move this check into
> cirrus_vga.c and vmware_vga.c. Even better would be to introduce a wrapper
> around callers of dpy_copy.
Yes, I don't think hw/ code should be concerned with what console is
active. Logically the dpy_ functions should take the pointer returned
from graphic_console_init() as first parameter.
Please also check the code is formatted consistently with qemu.
I didn't receive Jan's message but the check seems to not be enough
because there can be multiple graphical consoles with different sizes
- if I'm guessing correctly what this patch tries to fix.
Cheers
next prev parent reply other threads:[~2008-09-22 21:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 17:16 [Qemu-devel] [Patch] Segfault with -vnc option Jan Niehusmann
2008-09-22 18:08 ` [Qemu-devel] " Anthony Liguori
2008-09-22 21:15 ` andrzej zaborowski [this message]
2008-09-23 15:20 ` [Qemu-devel] [PATCH] Wrapper around dpy_copy to fix segfault " Jan Niehusmann
2008-09-24 2:27 ` [Qemu-devel] " andrzej zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb249edb0809221415j72203436ka786b9b97db78ee5@mail.gmail.com \
--to=balrogg@gmail.com \
--cc=jan@gondor.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).