From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KhskP-0007FU-43
	for qemu-devel@nongnu.org; Mon, 22 Sep 2008 17:15:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KhskN-0007F6-Jy
	for qemu-devel@nongnu.org; Mon, 22 Sep 2008 17:15:08 -0400
Received: from [199.232.76.173] (port=57396 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KhskN-0007F3-El
	for qemu-devel@nongnu.org; Mon, 22 Sep 2008 17:15:07 -0400
Received: from rv-out-0708.google.com ([209.85.198.241]:49948)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <balrogg@gmail.com>) id 1KhskN-0006kM-DD
	for qemu-devel@nongnu.org; Mon, 22 Sep 2008 17:15:07 -0400
Received: by rv-out-0708.google.com with SMTP id f25so1541736rvb.22
	for <qemu-devel@nongnu.org>; Mon, 22 Sep 2008 14:15:04 -0700 (PDT)
Message-ID: <fb249edb0809221415j72203436ka786b9b97db78ee5@mail.gmail.com>
Date: Mon, 22 Sep 2008 23:15:04 +0200
From: "andrzej zaborowski" <balrogg@gmail.com>
Subject: Re: [Qemu-devel] Re: [Patch] Segfault with -vnc option
In-Reply-To: <48D7DF10.4030004@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20080922171558.GA11353@x61s.gondor.com>
	<48D7DF10.4030004@codemonkey.ws>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Jan Niehusmann <jan@gondor.com>, kvm@vger.kernel.org

2008/9/22 Anthony Liguori <anthony@codemonkey.ws>:
> Jan Niehusmann wrote:
>>
>> Hi!
>>
>
> Hi Jan,
>
> Very good catch.  My only suggestion would be to move this check into
> cirrus_vga.c and vmware_vga.c.  Even better would be to introduce a wrapper
> around callers of dpy_copy.

Yes, I don't think hw/ code should be concerned with what console is
active.  Logically the dpy_ functions should take the pointer returned
from graphic_console_init() as first parameter.

Please also check the code is formatted consistently with qemu.

I didn't receive Jan's message but the check seems to not be enough
because there can be multiple graphical consoles with different sizes
- if I'm guessing correctly what this patch tries to fix.
Cheers