Re: [Qemu-devel] [PATCH 3 of 6] vga shared buffer

["andrzej zaborowski" <balrogg@gmail.com>]

2008/9/15 Anthony Liguori <anthony@codemonkey.ws>:
> Stefano Stabellini wrote:
>>
>> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>>
>
> I need to carve out some time to test this series and think about whether it
> can be done without adding a new DisplayState hook.  I should be able to
> respond or apply within a few days.

Any news? I think this change makes sense and it can help remove the
DIRECT_VRAM hack from vmware_vga.c.

>
> I'm concerned about the complexity this adds to back-ends.  It's not clear
> to me whether the performance justifies the added complexity.

One way to simplify this and everything else is use Stefano's code to
stop the backends (SDL, VNC) from managing the framebuffer altogether
and only support what these patches call shared buffer.  Then if the
given backed doesn't support given colorspace conversion in hardware,
it's its call to implement this, it could unify the color conversion
in qemu more generally.  The drawback is it's hard to support weird
colorspaces like those supported by OMAP2 display susbsystem, and even
harder to do features like overlaid framebuffers with different
colorspaces (but it's not currently implemented anyway).

Regards