From: "andrzej zaborowski" <balrogg@gmail.com>
To: qemu-devel@nongnu.org
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
michael@free-electrons.com
Subject: Re: [Qemu-devel] [patch 1/4] Increase write buffer size in pflash emulation
Date: Sat, 4 Oct 2008 01:05:55 +0200 [thread overview]
Message-ID: <fb249edb0810031605kb2468dg8b77ccec2a0b73fc@mail.gmail.com> (raw)
In-Reply-To: <20081002130238.239052598@free-electrons.com>
2008/10/2 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>:
> --- qemu.orig/hw/pflash_cfi01.c
> +++ qemu/hw/pflash_cfi01.c
> @@ -200,7 +200,7 @@
> {
> target_ulong boff;
> uint8_t *p;
> - uint8_t cmd;
> + uint16_t cmd;
>
> cmd = value;
I think the function of this assignment might have been to clip the
command to one byte also.
How about chaging pfl->counter = cmd; to pfl->counter = value;?
Cheers
next prev parent reply other threads:[~2008-10-03 23:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 13:02 [Qemu-devel] [patch 0/4] [RFC] Add flash emulation to the Versatile PB platform Thomas Petazzoni
2008-10-02 13:02 ` [Qemu-devel] [patch 1/4] Increase write buffer size in pflash emulation Thomas Petazzoni
2008-10-03 23:05 ` andrzej zaborowski [this message]
2008-10-06 9:47 ` Thomas Petazzoni
2008-10-02 13:02 ` [Qemu-devel] [patch 2/4] Reset wcycle after erase confirm Thomas Petazzoni
2008-10-02 13:02 ` [Qemu-devel] [patch 3/4] Improve pflash cfi01 debug messages Thomas Petazzoni
2008-10-02 13:02 ` [Qemu-devel] [patch 4/4] Add Flash support to the Versatile PB platform Thomas Petazzoni
2008-10-02 16:33 ` Paul Brook
2008-10-02 17:00 ` Thomas Petazzoni
2008-10-03 13:44 ` Thomas Petazzoni
2008-10-03 14:37 ` Thomas Petazzoni
2008-10-06 9:48 ` Thomas Petazzoni
2008-10-02 18:25 ` andrzej zaborowski
2008-10-03 7:55 ` Thomas Petazzoni
2008-10-06 17:23 ` [Qemu-devel] [Patch 0/4] [RFC] Zero Cluster Dedup, Offline dedup, qemu-img extentions Shahar Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb249edb0810031605kb2468dg8b77ccec2a0b73fc@mail.gmail.com \
--to=balrogg@gmail.com \
--cc=michael@free-electrons.com \
--cc=qemu-devel@nongnu.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).