From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kltii-0000hu-Rg
	for qemu-devel@nongnu.org; Fri, 03 Oct 2008 19:06:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kltig-0000hU-6i
	for qemu-devel@nongnu.org; Fri, 03 Oct 2008 19:05:59 -0400
Received: from [199.232.76.173] (port=36905 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kltig-0000hR-1L
	for qemu-devel@nongnu.org; Fri, 03 Oct 2008 19:05:58 -0400
Received: from rv-out-0708.google.com ([209.85.198.245]:2480)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <balrogg@gmail.com>) id 1Kltif-0004E9-LH
	for qemu-devel@nongnu.org; Fri, 03 Oct 2008 19:05:57 -0400
Received: by rv-out-0708.google.com with SMTP id f25so1631032rvb.22
	for <qemu-devel@nongnu.org>; Fri, 03 Oct 2008 16:05:55 -0700 (PDT)
Message-ID: <fb249edb0810031605kb2468dg8b77ccec2a0b73fc@mail.gmail.com>
Date: Sat, 4 Oct 2008 01:05:55 +0200
From: "andrzej zaborowski" <balrogg@gmail.com>
Subject: Re: [Qemu-devel] [patch 1/4] Increase write buffer size in pflash
	emulation
In-Reply-To: <20081002130238.239052598@free-electrons.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20081002130214.299833919@free-electrons.com>
	<20081002130238.239052598@free-electrons.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>, michael@free-electrons.com

2008/10/2 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>:
> --- qemu.orig/hw/pflash_cfi01.c
> +++ qemu/hw/pflash_cfi01.c
> @@ -200,7 +200,7 @@
>  {
>     target_ulong boff;
>     uint8_t *p;
> -    uint8_t cmd;
> +    uint16_t cmd;
>
>     cmd = value;

I think the function of this assignment might have been to clip the
command to one byte also.

How about chaging pfl->counter = cmd; to pfl->counter = value;?

Cheers