From: "andrzej zaborowski" <balrogg@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [patch 2/2] machine struct - specify max_cpus at the per machine level
Date: Tue, 7 Oct 2008 23:30:17 +0200 [thread overview]
Message-ID: <fb249edb0810071430g6fac2b10t49de9efc962ae4cf@mail.gmail.com> (raw)
In-Reply-To: <48EA0E7F.9090100@sgi.com>
2008/10/6 Jes Sorensen <jes@sgi.com>:
> --- qemu.orig/hw/an5206.c
> +++ qemu/hw/an5206.c
> @@ -92,4 +92,5 @@ QEMUMachine an5206_machine = {
> .desc = "Arnewsh 5206",
> .init = an5206_init,
> .ram_require = 512,
> + .max_cpus = 1,
> };
No machine has 0 cpus so there's no point specifying = 1 in every
machine instead of making it the default. The other fields were
thought so that they don't have to be specified except for non-default
values.
Cheers
next prev parent reply other threads:[~2008-10-07 21:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 13:11 [Qemu-devel] [patch 2/2] machine struct - specify max_cpus at the per machine level Jes Sorensen
2008-10-07 20:40 ` Anthony Liguori
2008-10-07 21:30 ` andrzej zaborowski [this message]
2008-10-08 13:40 ` Jes Sorensen
2008-10-09 2:05 ` andrzej zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb249edb0810071430g6fac2b10t49de9efc962ae4cf@mail.gmail.com \
--to=balrogg@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).