From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KnK8M-0008Vh-OF
	for qemu-devel@nongnu.org; Tue, 07 Oct 2008 17:30:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KnK8L-0008Ut-CG
	for qemu-devel@nongnu.org; Tue, 07 Oct 2008 17:30:22 -0400
Received: from [199.232.76.173] (port=42601 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KnK8L-0008Um-3z
	for qemu-devel@nongnu.org; Tue, 07 Oct 2008 17:30:21 -0400
Received: from rv-out-0708.google.com ([209.85.198.242]:56306)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <balrogg@gmail.com>) id 1KnK8K-0002zt-OE
	for qemu-devel@nongnu.org; Tue, 07 Oct 2008 17:30:21 -0400
Received: by rv-out-0708.google.com with SMTP id f25so3263712rvb.22
	for <qemu-devel@nongnu.org>; Tue, 07 Oct 2008 14:30:17 -0700 (PDT)
Message-ID: <fb249edb0810071430g6fac2b10t49de9efc962ae4cf@mail.gmail.com>
Date: Tue, 7 Oct 2008 23:30:17 +0200
From: "andrzej zaborowski" <balrogg@gmail.com>
Subject: Re: [Qemu-devel] [patch 2/2] machine struct - specify max_cpus at the
	per machine level
In-Reply-To: <48EA0E7F.9090100@sgi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <48EA0E7F.9090100@sgi.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

2008/10/6 Jes Sorensen <jes@sgi.com>:
> --- qemu.orig/hw/an5206.c
> +++ qemu/hw/an5206.c
> @@ -92,4 +92,5 @@ QEMUMachine an5206_machine = {
>     .desc = "Arnewsh 5206",
>     .init = an5206_init,
>     .ram_require = 512,
> +    .max_cpus = 1,
>  };

No machine has 0 cpus so there's no point specifying = 1 in every
machine instead of making it the default.  The other fields were
thought so that they don't have to be specified except for non-default
values.

Cheers