From: "andrzej zaborowski" <balrogg@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5531] Replace uses of strncpy (a GNU extension) with Qemu pstrcpy
Date: Sat, 25 Oct 2008 13:55:18 +0200 [thread overview]
Message-ID: <fb249edb0810250455o58cd4b93n1b0954a7e97f5819@mail.gmail.com> (raw)
In-Reply-To: <f43fc5580810250429l769f6647l13db4f660e8df2e5@mail.gmail.com>
2008/10/25 Blue Swirl <blauwirbel@gmail.com>:
> On 10/25/08, Blue Swirl <blauwirbel@gmail.com> wrote:
>> Revision: 5531
>> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5531
>> Author: blueswir1
>> Date: 2008-10-25 11:21:28 +0000 (Sat, 25 Oct 2008)
>>
>> Log Message:
>> -----------
>> Replace uses of strncpy (a GNU extension) with Qemu pstrcpy
>
> Actually, strncpy is not a GNU extension.
It's also not equivalent with pstrcpy because the latter always
appends a \0, so in the bt-hci.c case the original code was more
correct (but it only matters if a device's LMP name is exactly 248
chars long, which would be rare)
next prev parent reply other threads:[~2008-10-25 11:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-25 11:21 [Qemu-devel] [5531] Replace uses of strncpy (a GNU extension) with Qemu pstrcpy Blue Swirl
2008-10-25 11:29 ` Blue Swirl
2008-10-25 11:55 ` andrzej zaborowski [this message]
2008-10-25 18:47 ` malc
2008-10-26 10:14 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb249edb0810250455o58cd4b93n1b0954a7e97f5819@mail.gmail.com \
--to=balrogg@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).