From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kthjl-000683-HC for qemu-devel@nongnu.org; Sat, 25 Oct 2008 07:55:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kthjj-00067H-V0 for qemu-devel@nongnu.org; Sat, 25 Oct 2008 07:55:21 -0400 Received: from [199.232.76.173] (port=57384 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kthjj-00067A-Nu for qemu-devel@nongnu.org; Sat, 25 Oct 2008 07:55:19 -0400 Received: from rv-out-0708.google.com ([209.85.198.250]:43631) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kthjj-0002KC-E5 for qemu-devel@nongnu.org; Sat, 25 Oct 2008 07:55:19 -0400 Received: by rv-out-0708.google.com with SMTP id f25so1169870rvb.22 for ; Sat, 25 Oct 2008 04:55:18 -0700 (PDT) Message-ID: Date: Sat, 25 Oct 2008 13:55:18 +0200 From: "andrzej zaborowski" Subject: Re: [Qemu-devel] [5531] Replace uses of strncpy (a GNU extension) with Qemu pstrcpy In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org 2008/10/25 Blue Swirl : > On 10/25/08, Blue Swirl wrote: >> Revision: 5531 >> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5531 >> Author: blueswir1 >> Date: 2008-10-25 11:21:28 +0000 (Sat, 25 Oct 2008) >> >> Log Message: >> ----------- >> Replace uses of strncpy (a GNU extension) with Qemu pstrcpy > > Actually, strncpy is not a GNU extension. It's also not equivalent with pstrcpy because the latter always appends a \0, so in the bt-hci.c case the original code was more correct (but it only matters if a device's LMP name is exactly 248 chars long, which would be rare)